From: Sascha Hauer <s.hauer@pengutronix.de>
To: Moritz Augsburger <ml+barebox@moritz.augsburger.name>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] rpi: completed new revision scheme
Date: Tue, 29 Jan 2019 16:26:26 +0100 [thread overview]
Message-ID: <20190129152626.vipm6yi4ovel54oa@pengutronix.de> (raw)
In-Reply-To: <a391df2b46e827a4248821be10482999@moritz.augsburger.name>
On Mon, Jan 28, 2019 at 10:57:00AM +0100, Moritz Augsburger wrote:
> Hi Sascha,
>
> Am 2019-01-28 09:02, schrieb Sascha Hauer:
> > > static int rpi_board_rev = 0;
> > > @@ -211,10 +225,12 @@ static void rpi_get_board_rev(void)
> > > *
> > > http://www.raspberrypi.org/forums/viewtopic.php?f=31&t=20594
> > > */
> > > rpi_board_rev = msg->get_board_rev.body.resp.rev;
> > > + printf("RPI: Board rev %x\n", rpi_board_rev);
> > > if (rpi_board_rev & 0x800000) {
> > > rpi_board_rev = (rpi_board_rev >> 4) & 0xff;
> > > rpi_models = rpi_models_new_scheme;
> > > rpi_models_size = ARRAY_SIZE(rpi_models_new_scheme);
> > > + printf("RPI: Board rev %u new\n", rpi_board_rev);
> >
> > Are these printfs necessary? Looks like debugging aid. If yes, please
> > remove.
>
> You're right, they were overseen and are a debugging leftover.
>
> > Otherwise the patch looks fine, but I can't apply it due to whitespace
> > damages. Could you send it using git-send-emain? If that's no option
> > maybe a github pull request could do it.
>
> This time as attachement, hope it works better.
Indeed, yes. Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-29 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 16:28 Moritz Augsburger
2019-01-28 8:02 ` Sascha Hauer
2019-01-28 9:57 ` Moritz Augsburger
2019-01-29 15:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129152626.vipm6yi4ovel54oa@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ml+barebox@moritz.augsburger.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox