From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpYud-0002Fu-TA for barebox@lists.infradead.org; Fri, 01 Feb 2019 13:31:21 +0000 Date: Fri, 1 Feb 2019 14:31:08 +0100 From: Sam Ravnborg Message-ID: <20190201133108.GA14385@ravnborg.org> References: <20190201130241.26620-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190201130241.26620-1-l.stach@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] net: fec_imx: skip fec_halt if the FEC wasn't started To: Lucas Stach Cc: barebox@lists.infradead.org Hi Lucas. On Fri, Feb 01, 2019 at 02:02:41PM +0100, Lucas Stach wrote: > If the FEC driver is enabled, but the ethernet device was never > opened due to booting from another source the wait for graceful > transmit stop will always fail. This introduces an unnecessary > boot delay and prints a distracting warning. > > As there is no point in trying to shut down the FEC if it was > never started, just skip all of fec_halt in that case. > > Signed-off-by: Lucas Stach > --- > drivers/net/fec_imx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c > index 4823b08340c6..36505c529c84 100644 > --- a/drivers/net/fec_imx.c > +++ b/drivers/net/fec_imx.c > @@ -395,6 +395,9 @@ static void fec_halt(struct eth_device *dev) > struct fec_priv *fec = (struct fec_priv *)dev->priv; > uint32_t reg; > > + if (!(readl(fec->regs + FEC_ECNTRL) & FEC_ECNTRL_ETHER_EN)) > + return; > + It would be nice with a small comment in the code that explain why it is OK to return here, so one does not have to go digging in git to find out why. Sam _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox