From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Hemp <christian.hemp@posteo.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: phyCORE-i.MX8M SOM support
Date: Mon, 11 Feb 2019 09:20:23 +0100 [thread overview]
Message-ID: <20190211082023.up4tbownps6yyvmo@pengutronix.de> (raw)
In-Reply-To: <20190206184122.14423-1-christian.hemp@posteo.de>
Hi Christian,
On Wed, Feb 06, 2019 at 07:41:22PM +0100, Christian Hemp wrote:
> The phyCORE-i.MX8M aka PCL-066 is a SoM containing a i.MX8M SoC.
>
> phyCORE-i.MX8M:
> - 1GB LPDDR4 RAM
> - eMMC
> - microSD
> - Ethernet
> > +
> diff --git a/arch/arm/dts/imx8mq-phytec-phycore-som.dts b/arch/arm/dts/imx8mq-phytec-phycore-som.dts
> new file mode 100644
> index 000000000..7b566e32b
> --- /dev/null
> +++ b/arch/arm/dts/imx8mq-phytec-phycore-som.dts
> @@ -0,0 +1,328 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2018 Christian Hemp <christian.hemp@posteo.de>
> + */
> +
> +/dts-v1/;
> +
> +#include <arm64/freescale/imx8mq.dtsi>
> +#include <dt-bindings/net/ti-dp83867.h>
> +#include "imx8mq.dtsi"
> +#include "imx8mq-ddrc.dtsi"
> +
> +/ {
> + model = "Phytec phyCORE-i.MX8";
> + compatible = "phytec,imx8mq-pcl066", "fsl,imx8mq";
> +
> + chosen {
> + stdout-path = &uart1;
> +
> + environment-emmc {
> + compatible = "barebox,environment";
> + device-path = &usdhc1, "partname:barebox-environment";
> + status = "disabled";
> + };
> +
> + environment-sd {
> + compatible = "barebox,environment";
> + device-path = &usdhc2, "partname:barebox-environment";
> + status = "disabled";
> + };
I pretty much prefer adding a phandle to the partition itself rather
than using this "partname:" mechanism.
Otherwise the patch looks good to me.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-11 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 18:41 Christian Hemp
2019-02-07 1:20 ` Andrey Smirnov
2019-02-11 8:20 ` Sascha Hauer [this message]
2019-02-11 11:00 ` Lucas Stach
2019-02-13 6:14 ` Oleksij Rempel
2019-02-14 18:20 ` Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211082023.up4tbownps6yyvmo@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=christian.hemp@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox