[PATCH] watchdog: bcm2835: set timeout_max.

[PATCH] watchdog: bcm2835: set timeout_max.

[Tomaz Solc]

BCM2835 watchdog timeout can be set to maximum 15 seconds (0xffffff >> 16).
---
 drivers/watchdog/bcm2835_wdt.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
index d0c51ed9e..781626fa0 100644
--- a/drivers/watchdog/bcm2835_wdt.c
+++ b/drivers/watchdog/bcm2835_wdt.c
@@ -45,6 +45,10 @@
 
 #define SECS_TO_WDOG_TICKS(x) ((x) << 16)
 
+/* Largest value where SECS_TO_WDOG_TICKS doesn't overflow 20 bits
+ * (PM_WDOG_TIME_SET) */
+#define WDOG_SECS_MAX 15
+
 struct bcm2835_wd {
 	struct watchdog wd;
 	void __iomem *base;
@@ -101,6 +105,7 @@ static int bcm2835_wd_probe(struct device_d *dev)
 	}
 	priv->base = IOMEM(iores->start);
 	priv->wd.set_timeout = bcm2835_wd_set_timeout;
+	priv->wd.timeout_max = WDOG_SECS_MAX;
 	priv->wd.hwdev = dev;
 	priv->dev = dev;
 
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] watchdog: bcm2835: set timeout_max.

[Sascha Hauer]

On Thu, Feb 14, 2019 at 02:36:34PM +0100, Tomaz Solc wrote:
> BCM2835 watchdog timeout can be set to maximum 15 seconds (0xffffff >> 16).
> ---
>  drivers/watchdog/bcm2835_wdt.c | 5 +++++
>  1 file changed, 5 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index d0c51ed9e..781626fa0 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -45,6 +45,10 @@
>  
>  #define SECS_TO_WDOG_TICKS(x) ((x) << 16)
>  
> +/* Largest value where SECS_TO_WDOG_TICKS doesn't overflow 20 bits
> + * (PM_WDOG_TIME_SET) */
> +#define WDOG_SECS_MAX 15
> +
>  struct bcm2835_wd {
>  	struct watchdog wd;
>  	void __iomem *base;
> @@ -101,6 +105,7 @@ static int bcm2835_wd_probe(struct device_d *dev)
>  	}
>  	priv->base = IOMEM(iores->start);
>  	priv->wd.set_timeout = bcm2835_wd_set_timeout;
> +	priv->wd.timeout_max = WDOG_SECS_MAX;
>  	priv->wd.hwdev = dev;
>  	priv->dev = dev;
>  
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox