From: Sascha Hauer <s.hauer@pengutronix.de>
To: Tomaz Solc <tomaz.solc@tablix.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] watchdog: bcm2835: set timeout_max.
Date: Mon, 18 Feb 2019 09:48:59 +0100 [thread overview]
Message-ID: <20190218084859.kcqwqlx4ipsqpzfd@pengutronix.de> (raw)
In-Reply-To: <20190214133634.7669-1-tomaz.solc@tablix.org>
On Thu, Feb 14, 2019 at 02:36:34PM +0100, Tomaz Solc wrote:
> BCM2835 watchdog timeout can be set to maximum 15 seconds (0xffffff >> 16).
> ---
> drivers/watchdog/bcm2835_wdt.c | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index d0c51ed9e..781626fa0 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -45,6 +45,10 @@
>
> #define SECS_TO_WDOG_TICKS(x) ((x) << 16)
>
> +/* Largest value where SECS_TO_WDOG_TICKS doesn't overflow 20 bits
> + * (PM_WDOG_TIME_SET) */
> +#define WDOG_SECS_MAX 15
> +
> struct bcm2835_wd {
> struct watchdog wd;
> void __iomem *base;
> @@ -101,6 +105,7 @@ static int bcm2835_wd_probe(struct device_d *dev)
> }
> priv->base = IOMEM(iores->start);
> priv->wd.set_timeout = bcm2835_wd_set_timeout;
> + priv->wd.timeout_max = WDOG_SECS_MAX;
> priv->wd.hwdev = dev;
> priv->dev = dev;
>
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-02-18 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:36 Tomaz Solc
2019-02-18 8:48 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218084859.kcqwqlx4ipsqpzfd@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=tomaz.solc@tablix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox