From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org,
"Thorsten K . Scherer" <t.scherer@eckelmann.de>
Subject: Re: [PATCH 1/2] imd: create new helper macro to add data from oftree to image meta data
Date: Fri, 22 Feb 2019 09:11:39 +0100 [thread overview]
Message-ID: <20190222081139.wf775ytgd6zerdsv@pengutronix.de> (raw)
In-Reply-To: <20190221102531.25291-1-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On Thu, Feb 21, 2019 at 11:25:30AM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> include/image-metadata.h | 4 ++++
> scripts/gen-dtb-s | 4 ++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/include/image-metadata.h b/include/image-metadata.h
> index 8739bffb92e1..5904d95acd37 100644
> --- a/include/image-metadata.h
> +++ b/include/image-metadata.h
> @@ -118,6 +118,10 @@ static inline void imd_used(const void *unused)
>
> #define IMD_USED(_name) \
> imd_used(&__barebox_imd_##_name)
> +#define IMD_USED_OF(_name) ({ \
> + extern char __barebox_imd_OF_ ## _name[]; \
> + imd_used(&__barebox_imd_OF_ ## _name); \
> + })
>
> #endif /* __BAREBOX__ */
>
> diff --git a/scripts/gen-dtb-s b/scripts/gen-dtb-s
> index 2b44ffb361eb..c3144df851bf 100755
> --- a/scripts/gen-dtb-s
> +++ b/scripts/gen-dtb-s
> @@ -18,8 +18,8 @@ FDTGET=scripts/dtc/fdtget
>
> if [ "$imd" = "y" ]; then
> echo ".section .barebox_imd_0.${name},\"a\""
> - echo ".global __imd_${name}_start"
> - echo "__imd_${name}_start:"
> + echo ".global __barebox_imd_OF_${name}"
> + echo "__barebox_imd_OF_${name}:"
This breaks somewhere when the compressed variants of the dtbs are used.
Building imx_v7_defconfig fails here with:
arch/arm/dts/built-in-pbl.o: In function `__dtb_z_imx6dl_wandboard_end':
arch/arm/dts/pbl-vf610-zii-ssmb-spu3.dtb.o:(.dtbz.rodata.imx6dl_wandboard+0x2340): undefined reference to `__imd_imx6dl_wandboard_start'
OBJCOPYB images/start_imx6dl_nitrogen6x_1g.pblb
arch/arm/dts/built-in-pbl.o: In function `__dtb_z_imx6q_wandboard_end':
arch/arm/dts/pbl-vf610-zii-ssmb-spu3.dtb.o:(.dtbz.rodata.imx6q_wandboard+0x2320): undefined reference to `__imd_imx6q_wandboard_start'
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-22 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:25 Uwe Kleine-König
2019-02-21 10:25 ` [PATCH 2/2] ARM: phytec-som-imx6: make use of new imd oftree helper Uwe Kleine-König
2019-02-22 8:11 ` Sascha Hauer [this message]
2019-02-22 21:22 ` [PATCH 1/2] imd: create new helper macro to add data from oftree to image meta data Uwe Kleine-König
2019-02-25 8:41 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222081139.wf775ytgd6zerdsv@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.scherer@eckelmann.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox