mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Christian Hemp <christian.hemp@posteo.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] ARM: phyCORE-i.MX8M SOM support
Date: Sun, 24 Feb 2019 13:47:15 +0100	[thread overview]
Message-ID: <20190224124715.GC19669@ravnborg.org> (raw)
In-Reply-To: <20190221192411.8395-1-christian.hemp@posteo.de>

Hi Christian.

On Thu, Feb 21, 2019 at 08:24:11PM +0100, Christian Hemp wrote:
> The phyCORE-i.MX8M aka PCL-066 is a SoM containing a i.MX8M SoC.
> 
> phyCORE-i.MX8M:
>  - 1GB LPDDR4 RAM
>  - eMMC
>  - microSD
>  - Ethernet
> 
> Signed-off-by: Christian Hemp <christian.hemp@posteo.de>

I browsed the patch - and everything looked good.
This is code that I am not familiar so it cannot count
for a review - but you may add my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

(I do not like all these random numbers, but I learned that
this is just the way it is.
And my OCD shall accept missing spaces after ',' as this
is auto generated).

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-02-24 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 19:24 Christian Hemp
2019-02-24 12:47 ` Sam Ravnborg [this message]
2019-02-25  8:14 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190224124715.GC19669@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=christian.hemp@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox