From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marcin Niestroj <m.niestroj@grinn-global.com>
Cc: barebox@lists.infradead.org, Bartosz Bilas <b.bilas@grinn-global.com>
Subject: Re: [PATCH] ARM: i.MX6UL: liteSOM: depend on DDR controller settings
Date: Wed, 27 Feb 2019 08:46:36 +0100 [thread overview]
Message-ID: <20190227074636.s5ljrhjncx2uv5ei@pengutronix.de> (raw)
In-Reply-To: <20190226130529.12517-1-m.niestroj@grinn-global.com>
On Tue, Feb 26, 2019 at 02:05:29PM +0100, Marcin Niestroj wrote:
> Initially we depended on DDR controller settings for liteSOM and liteboard. With
> 33fdc89d4cbd ("dts: update to v5.0-rc1") a `device_type = "memory";` property
> was added to imx6ul-litesom.dtsi file, which causes "ram0" to be added with
> 512MB size (value in dtsi) instead of the real 256MB size that is configured in
> barebox-grinn-liteboard-256mb.img. As a result Linux kernel fails to boot.
>
> Lets depend on DDR controller settings, by removing whole `/memory` node from
> device tree. This makes barebox-grinn-liteboard-256mb.img able to boot Linux
> kernel once again.
This issue should also be fixed by:
| commit 8a29e7b493c8c2aa57174c9e79c14b93c9807a4b
| Author: Marco Felsch <m.felsch@pengutronix.de>
| Date: Tue Feb 12 16:10:41 2019 +0100
|
| memory: of_fixup: adapt to new memory layout
|
| Since kernel 4.16 the memory nodes got a @<reg> suffix so the fixup
| won't work correctly anymore, because instead of adapting the extisting
| one the fixup creates a new node and keeps the old (maybe incorrect)
| node.
|
| To be compatible with the old and new layout delete the found memory
| node and create a new one. The new node follows the new @<reg> style.
|
| The patch also renames the node parameter to make it clearer.
|
| Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
| Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
I would prefer this patch as it solves the issue for all boards.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-27 7:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 13:05 Marcin Niestroj
2019-02-26 18:35 ` Bartosz Biłas
2019-02-27 7:46 ` Sascha Hauer [this message]
2019-02-27 10:04 ` Marcin Niestrój
2019-03-07 7:24 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227074636.s5ljrhjncx2uv5ei@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=b.bilas@grinn-global.com \
--cc=barebox@lists.infradead.org \
--cc=m.niestroj@grinn-global.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox