From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gytvK-0001r8-MM for barebox@lists.infradead.org; Wed, 27 Feb 2019 07:46:40 +0000 Date: Wed, 27 Feb 2019 08:46:36 +0100 From: Sascha Hauer Message-ID: <20190227074636.s5ljrhjncx2uv5ei@pengutronix.de> References: <20190226130529.12517-1-m.niestroj@grinn-global.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190226130529.12517-1-m.niestroj@grinn-global.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: i.MX6UL: liteSOM: depend on DDR controller settings To: Marcin Niestroj Cc: barebox@lists.infradead.org, Bartosz Bilas On Tue, Feb 26, 2019 at 02:05:29PM +0100, Marcin Niestroj wrote: > Initially we depended on DDR controller settings for liteSOM and liteboard. With > 33fdc89d4cbd ("dts: update to v5.0-rc1") a `device_type = "memory";` property > was added to imx6ul-litesom.dtsi file, which causes "ram0" to be added with > 512MB size (value in dtsi) instead of the real 256MB size that is configured in > barebox-grinn-liteboard-256mb.img. As a result Linux kernel fails to boot. > > Lets depend on DDR controller settings, by removing whole `/memory` node from > device tree. This makes barebox-grinn-liteboard-256mb.img able to boot Linux > kernel once again. This issue should also be fixed by: | commit 8a29e7b493c8c2aa57174c9e79c14b93c9807a4b | Author: Marco Felsch | Date: Tue Feb 12 16:10:41 2019 +0100 | | memory: of_fixup: adapt to new memory layout | | Since kernel 4.16 the memory nodes got a @ suffix so the fixup | won't work correctly anymore, because instead of adapting the extisting | one the fixup creates a new node and keeps the old (maybe incorrect) | node. | | To be compatible with the old and new layout delete the found memory | node and create a new one. The new node follows the new @ style. | | The patch also renames the node parameter to make it clearer. | | Signed-off-by: Marco Felsch | Signed-off-by: Sascha Hauer I would prefer this patch as it solves the issue for all boards. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox