From: Michael Olbrich <m.olbrich@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: [PATCH] i.MX habv3: add missing includes and make locally used function static
Date: Sat, 2 Mar 2019 11:18:13 +0100 [thread overview]
Message-ID: <20190302101813.13998-1-m.olbrich@pengutronix.de> (raw)
Without this building fails with:
drivers/hab/habv3.c:80:12: error: static declaration of 'imx25_hab_get_status' follows non-static declaration
In file included from drivers/hab/habv3.c:14:
include/hab.h:39:5: note: previous declaration of 'imx25_hab_get_status' was here
drivers/hab/habv3.c:87:1: warning: data definition has no type or storage class
drivers/hab/habv3.c:87:1: warning: type defaults to 'int' in declaration of 'postmmu_initcall' [-Wimplicit-int]
drivers/hab/habv3.c:87:1: warning: parameter names (without types) in function declaration
drivers/hab/habv3.c:80:12: warning: 'imx25_hab_get_status' defined but not used [-Wunused-function]
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
drivers/hab/habv3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hab/habv3.c b/drivers/hab/habv3.c
index 47d3caf864ec..f3f94bc44c8c 100644
--- a/drivers/hab/habv3.c
+++ b/drivers/hab/habv3.c
@@ -10,9 +10,11 @@
*/
#define pr_fmt(fmt) "HABv3: " fmt
+#include <init.h>
#include <common.h>
#include <hab.h>
#include <io.h>
+#include <mach/generic.h>
struct hab_status {
u8 value;
@@ -55,7 +57,7 @@ static struct hab_status hab_status[] = {
{ 0x8e, "algorithm type is either invalid or ortherwise unsupported" },
};
-int imx_habv3_get_status(uint32_t status)
+static int imx_habv3_get_status(uint32_t status)
{
int i;
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-03-02 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 10:18 Michael Olbrich [this message]
2019-03-04 8:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302101813.13998-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox