mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/6] ddr_spd: Add function to read eeprom
Date: Mon, 4 Mar 2019 14:22:45 +0100	[thread overview]
Message-ID: <20190304132245.ahwozoh6y2gtibi2@pengutronix.de> (raw)
In-Reply-To: <20190304120252.GC16532@ravnborg.org>

Hi Sam,

On Mon, Mar 04, 2019 at 01:02:52PM +0100, Sam Ravnborg wrote:
> Hi Sascha
> 
> On Mon, Mar 04, 2019 at 12:38:21PM +0100, Sascha Hauer wrote:
> > +/**
> > + * spd_read_eeprom - Read contents of a SPD EEPROM
> > + * @ctx: Context pointer for the xfer function
> > + * @xfer: I2C message transfer function
> > + * @addr: I2C bus address for the EEPROM
> > + * @buf: buffer to read the SPD data to
> It is not obvious what buffer size to provide here.
> And if it happens to be SPD_MEMTYPE_DDR4 then we suddenly start to
> write data at offset 256 in the buffer.
> So maybe add a small comment that this should always be 512 bytes.
> Or even better 2 x SPD_PAGE_SIZE (defined to 256)

Make sense, I added such a comment.

Thanks
Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-03-04 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 11:38 [PATCH 0/6] SPD EEPROM improvements Sascha Hauer
2019-03-04 11:38 ` [PATCH 1/6] crc: import crc_itu_t() from kernel Sascha Hauer
2019-03-04 11:50   ` Sam Ravnborg
2019-03-04 13:19     ` Sascha Hauer
2019-03-04 11:38 ` [PATCH 2/6] crc: Add PBL variant for crc_itu_t() Sascha Hauer
2019-03-04 11:38 ` [PATCH 3/6] ddr_spd: Update from U-Boot Sascha Hauer
2019-03-04 11:38 ` [PATCH 4/6] ddr_spd: Add function to read eeprom Sascha Hauer
2019-03-04 11:53   ` Sam Ravnborg
2019-03-04 12:02   ` Sam Ravnborg
2019-03-04 13:22     ` Sascha Hauer [this message]
2019-03-04 11:38 ` [PATCH 5/6] ddr_spd: provide common SPD type Sascha Hauer
2019-03-04 11:38 ` [PATCH 6/6] ddr_spd: Enable in PBL Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304132245.ahwozoh6y2gtibi2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox