From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1nmr-0005Lq-Ol for barebox@lists.infradead.org; Thu, 07 Mar 2019 07:50:02 +0000 Received: by mail-pg1-x544.google.com with SMTP id h8so10614976pgp.6 for ; Wed, 06 Mar 2019 23:49:53 -0800 (PST) From: Andrey Smirnov Date: Wed, 6 Mar 2019 23:49:26 -0800 Message-Id: <20190307074926.20539-18-andrew.smirnov@gmail.com> In-Reply-To: <20190307074926.20539-1-andrew.smirnov@gmail.com> References: <20190307074926.20539-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 17/17] commands: loadb: Make use of open_and_lseek() To: barebox@lists.infradead.org Cc: Andrey Smirnov Save a bit of extra code by replacing explict calls to open() and lseek() with a single call to open_and_lseek(). Signed-off-by: Andrey Smirnov --- commands/loadb.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/commands/loadb.c b/commands/loadb.c index 8c3906ca4..a1f6e63ec 100644 --- a/commands/loadb.c +++ b/commands/loadb.c @@ -661,21 +661,11 @@ static int do_load_serial_bin(int argc, char *argv[]) output_file = DEF_FILE; /* File should exist */ - ofd = open(output_file, O_WRONLY | O_CREAT); + ofd = open_and_lseek(output_file, O_WRONLY | O_CREAT, offset); if (ofd < 0) { perror(argv[0]); return 3; } - /* Seek to the right offset */ - if (offset) { - int seek = lseek(ofd, offset, SEEK_SET); - if (seek != offset) { - close(ofd); - ofd = 0; - perror(argv[0]); - return 4; - } - } printf("## Ready for binary (kermit) download " "to 0x%08lX offset on %s device at %d bps...\n", offset, -- 2.20.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox