[PATCH 1/3] fs: ramfs: Drop unused 'handle' filed from struct ramfs_inode

[PATCH 1/3] fs: ramfs: Drop unused 'handle' filed from struct ramfs_inode

[Andrey Smirnov]

There are no users of this field in the code. Drop it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 fs/ramfs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 3046afef3..94ecb0597 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -43,8 +43,6 @@ struct ramfs_inode {
 	char *symlink;
 	ulong mode;
 
-	struct handle_d *handle;
-
 	ulong size;
 	struct ramfs_chunk *data;
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/3] fs: ramfs: Drop unused 'chunks' conter

[Andrey Smirnov]

This variable doesn't appear to be used anywhere in the code. Drop it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 fs/ramfs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 94ecb0597..eec7cfb5b 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -99,8 +99,6 @@ static struct inode *ramfs_get_inode(struct super_block *sb, const struct inode
 	return inode;
 }
 
-static int chunks = 0;
-
 static struct ramfs_chunk *ramfs_get_chunk(void)
 {
 	struct ramfs_chunk *data = malloc(sizeof(struct ramfs_chunk));
@@ -113,7 +111,6 @@ static struct ramfs_chunk *ramfs_get_chunk(void)
 		return NULL;
 	}
 	data->next = NULL;
-	chunks++;
 
 	return data;
 }
@@ -122,7 +119,6 @@ static void ramfs_put_chunk(struct ramfs_chunk *data)
 {
 	free(data->data);
 	free(data);
-	chunks--;
 }
 
 /* ---------------------------------------------------------------*/
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/3] fs: ramfs: Drop unnecessary check in ramfs_mknod()

[Andrey Smirnov]

There's already an early exit statement triggered by "inode" being
NULL. Drop an extra check that will always be true.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 fs/ramfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index eec7cfb5b..7e7dc7aca 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -131,10 +131,8 @@ ramfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode)
 	if (!inode)
 		return -ENOSPC;
 
-	if (inode) {
-		d_instantiate(dentry, inode);
-		dget(dentry);   /* Extra count - pin the dentry in core */
-	}
+	d_instantiate(dentry, inode);
+	dget(dentry);   /* Extra count - pin the dentry in core */
 
 	return 0;
 }
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/3] fs: ramfs: Drop unused 'handle' filed from struct ramfs_inode

[Sascha Hauer]

On Tue, Mar 12, 2019 at 12:21:48AM -0700, Andrey Smirnov wrote:
> There are no users of this field in the code. Drop it.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  fs/ramfs.c | 2 --
>  1 file changed, 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/ramfs.c b/fs/ramfs.c
> index 3046afef3..94ecb0597 100644
> --- a/fs/ramfs.c
> +++ b/fs/ramfs.c
> @@ -43,8 +43,6 @@ struct ramfs_inode {
>  	char *symlink;
>  	ulong mode;
>  
> -	struct handle_d *handle;
> -
>  	ulong size;
>  	struct ramfs_chunk *data;
>  
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox