mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: rpi: add board revision for Compute Module 3+
@ 2019-03-25 14:34 Tomaz Solc
  2019-03-27  7:44 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Tomaz Solc @ 2019-03-25 14:34 UTC (permalink / raw)
  To: barebox

---
 arch/arm/boards/raspberry-pi/rpi-common.c | 2 ++
 arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
index 60cea7f8e..bc877f853 100644
--- a/arch/arm/boards/raspberry-pi/rpi-common.c
+++ b/arch/arm/boards/raspberry-pi/rpi-common.c
@@ -197,6 +197,8 @@ const struct rpi_model rpi_models_new_scheme[] = {
 	RPI_MODEL(BCM2835_BOARD_REV_ZERO_W, 	"Zero W", 	rpi_b_plus_init),
 	RPI_MODEL(BCM2837B0_BOARD_REV_3B_PLUS, 	"Model 3 B+", 	rpi_b_plus_init ),
 	RPI_MODEL(BCM2837B0_BOARD_REV_3A_PLUS, 	"Nodel 3 A+", 	rpi_b_plus_init),
+	RPI_MODEL(0xf, "Unknown model", NULL),
+	RPI_MODEL(BCM2837B0_BOARD_REV_CM3_PLUS, "Compute Module 3+", NULL),
 };
 
 static int rpi_board_rev = 0;
diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
index e4f6cb675..6db961b80 100644
--- a/arch/arm/mach-bcm283x/include/mach/mbox.h
+++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
@@ -166,6 +166,7 @@ struct bcm2835_mbox_tag_hdr {
 #define BCM2835_BOARD_REV_ZERO_W   	0x0c
 #define BCM2837B0_BOARD_REV_3B_PLUS   	0x0d
 #define BCM2837B0_BOARD_REV_3A_PLUS   	0x0e
+#define BCM2837B0_BOARD_REV_CM3_PLUS	0x10
 
 struct bcm2835_mbox_tag_get_board_rev {
 	struct bcm2835_mbox_tag_hdr tag_hdr;
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: rpi: add board revision for Compute Module 3+
  2019-03-25 14:34 [PATCH] ARM: rpi: add board revision for Compute Module 3+ Tomaz Solc
@ 2019-03-27  7:44 ` Sascha Hauer
  2019-03-27  8:30   ` [PATCH v2] " Tomaz Solc
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2019-03-27  7:44 UTC (permalink / raw)
  To: Tomaz Solc; +Cc: barebox

Hi Tomaz,

The patch itself looks good. Please resend with a Signed-off-by tag.

Sascha

On Mon, Mar 25, 2019 at 03:34:10PM +0100, Tomaz Solc wrote:
> ---
>  arch/arm/boards/raspberry-pi/rpi-common.c | 2 ++
>  arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
> index 60cea7f8e..bc877f853 100644
> --- a/arch/arm/boards/raspberry-pi/rpi-common.c
> +++ b/arch/arm/boards/raspberry-pi/rpi-common.c
> @@ -197,6 +197,8 @@ const struct rpi_model rpi_models_new_scheme[] = {
>  	RPI_MODEL(BCM2835_BOARD_REV_ZERO_W, 	"Zero W", 	rpi_b_plus_init),
>  	RPI_MODEL(BCM2837B0_BOARD_REV_3B_PLUS, 	"Model 3 B+", 	rpi_b_plus_init ),
>  	RPI_MODEL(BCM2837B0_BOARD_REV_3A_PLUS, 	"Nodel 3 A+", 	rpi_b_plus_init),
> +	RPI_MODEL(0xf, "Unknown model", NULL),
> +	RPI_MODEL(BCM2837B0_BOARD_REV_CM3_PLUS, "Compute Module 3+", NULL),
>  };
>  
>  static int rpi_board_rev = 0;
> diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
> index e4f6cb675..6db961b80 100644
> --- a/arch/arm/mach-bcm283x/include/mach/mbox.h
> +++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
> @@ -166,6 +166,7 @@ struct bcm2835_mbox_tag_hdr {
>  #define BCM2835_BOARD_REV_ZERO_W   	0x0c
>  #define BCM2837B0_BOARD_REV_3B_PLUS   	0x0d
>  #define BCM2837B0_BOARD_REV_3A_PLUS   	0x0e
> +#define BCM2837B0_BOARD_REV_CM3_PLUS	0x10
>  
>  struct bcm2835_mbox_tag_get_board_rev {
>  	struct bcm2835_mbox_tag_hdr tag_hdr;
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v2] ARM: rpi: add board revision for Compute Module 3+
  2019-03-27  7:44 ` Sascha Hauer
@ 2019-03-27  8:30   ` Tomaz Solc
  2019-03-27  8:43     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Tomaz Solc @ 2019-03-27  8:30 UTC (permalink / raw)
  To: barebox

Raspberry Pi Compute Module 3+ was released in January 2019.

Source for the new board revision code:

https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md

Signed-off-by: Tomaz Solc <tomaz.solc@tablix.org>
---
 arch/arm/boards/raspberry-pi/rpi-common.c | 2 ++
 arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
index 60cea7f8e..bc877f853 100644
--- a/arch/arm/boards/raspberry-pi/rpi-common.c
+++ b/arch/arm/boards/raspberry-pi/rpi-common.c
@@ -197,6 +197,8 @@ const struct rpi_model rpi_models_new_scheme[] = {
 	RPI_MODEL(BCM2835_BOARD_REV_ZERO_W, 	"Zero W", 	rpi_b_plus_init),
 	RPI_MODEL(BCM2837B0_BOARD_REV_3B_PLUS, 	"Model 3 B+", 	rpi_b_plus_init ),
 	RPI_MODEL(BCM2837B0_BOARD_REV_3A_PLUS, 	"Nodel 3 A+", 	rpi_b_plus_init),
+	RPI_MODEL(0xf, "Unknown model", NULL),
+	RPI_MODEL(BCM2837B0_BOARD_REV_CM3_PLUS, "Compute Module 3+", NULL),
 };
 
 static int rpi_board_rev = 0;
diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
index e4f6cb675..6db961b80 100644
--- a/arch/arm/mach-bcm283x/include/mach/mbox.h
+++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
@@ -166,6 +166,7 @@ struct bcm2835_mbox_tag_hdr {
 #define BCM2835_BOARD_REV_ZERO_W   	0x0c
 #define BCM2837B0_BOARD_REV_3B_PLUS   	0x0d
 #define BCM2837B0_BOARD_REV_3A_PLUS   	0x0e
+#define BCM2837B0_BOARD_REV_CM3_PLUS	0x10
 
 struct bcm2835_mbox_tag_get_board_rev {
 	struct bcm2835_mbox_tag_hdr tag_hdr;
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: rpi: add board revision for Compute Module 3+
  2019-03-27  8:30   ` [PATCH v2] " Tomaz Solc
@ 2019-03-27  8:43     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2019-03-27  8:43 UTC (permalink / raw)
  To: Tomaz Solc; +Cc: barebox

On Wed, Mar 27, 2019 at 09:30:10AM +0100, Tomaz Solc wrote:
> Raspberry Pi Compute Module 3+ was released in January 2019.
> 
> Source for the new board revision code:
> 
> https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
> 
> Signed-off-by: Tomaz Solc <tomaz.solc@tablix.org>
> ---

Applied, thanks

Sascha

>  arch/arm/boards/raspberry-pi/rpi-common.c | 2 ++
>  arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
> index 60cea7f8e..bc877f853 100644
> --- a/arch/arm/boards/raspberry-pi/rpi-common.c
> +++ b/arch/arm/boards/raspberry-pi/rpi-common.c
> @@ -197,6 +197,8 @@ const struct rpi_model rpi_models_new_scheme[] = {
>  	RPI_MODEL(BCM2835_BOARD_REV_ZERO_W, 	"Zero W", 	rpi_b_plus_init),
>  	RPI_MODEL(BCM2837B0_BOARD_REV_3B_PLUS, 	"Model 3 B+", 	rpi_b_plus_init ),
>  	RPI_MODEL(BCM2837B0_BOARD_REV_3A_PLUS, 	"Nodel 3 A+", 	rpi_b_plus_init),
> +	RPI_MODEL(0xf, "Unknown model", NULL),
> +	RPI_MODEL(BCM2837B0_BOARD_REV_CM3_PLUS, "Compute Module 3+", NULL),
>  };
>  
>  static int rpi_board_rev = 0;
> diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
> index e4f6cb675..6db961b80 100644
> --- a/arch/arm/mach-bcm283x/include/mach/mbox.h
> +++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
> @@ -166,6 +166,7 @@ struct bcm2835_mbox_tag_hdr {
>  #define BCM2835_BOARD_REV_ZERO_W   	0x0c
>  #define BCM2837B0_BOARD_REV_3B_PLUS   	0x0d
>  #define BCM2837B0_BOARD_REV_3A_PLUS   	0x0e
> +#define BCM2837B0_BOARD_REV_CM3_PLUS	0x10
>  
>  struct bcm2835_mbox_tag_get_board_rev {
>  	struct bcm2835_mbox_tag_hdr tag_hdr;
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-27  8:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 14:34 [PATCH] ARM: rpi: add board revision for Compute Module 3+ Tomaz Solc
2019-03-27  7:44 ` Sascha Hauer
2019-03-27  8:30   ` [PATCH v2] " Tomaz Solc
2019-03-27  8:43     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox