From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: barebox@lists.infradead.org
Subject: Re: watchdog_disable() in Cyclone V reset manager
Date: Wed, 10 Apr 2019 08:21:17 +0200 [thread overview]
Message-ID: <20190410062117.hy6az4zojslvtvfs@pengutronix.de> (raw)
In-Reply-To: <67655ee5-da5f-2b99-2d1d-ab6c66e4dd48@mev.co.uk>
On Mon, Apr 08, 2019 at 03:10:06PM +0100, Ian Abbott wrote:
> "arch/arm/mach-socfpga/cyclone5-reset-manager.c" defines a global function
> 'void watchdog_disable(void)'. Nothing calls it. The compiler issues a
> warning:
>
> /mnt/lindata/work/abbotti/barebox_git/barebox-next/arch/arm/mach-socfpga/cyclone5-reset-manager.c:26:6:
> warning: no previous prototype for ‘watchdog_disable’ [-Wmissing-prototypes]
> void watchdog_disable(void)
> ^~~~~~~~~~~~~~~~
>
> Since nothing in the shipped code calls it, should we get rid of it? If
> not, it should be declared in a header file somewhere.
watchdog_disable() goes back to the initial socfpga commit, so when
nothing uses it now I think we can remove it. The watchdog disabling
may also be handled already in socfpga_lowlevel_init() which also
touches the same registers.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-04-10 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:10 Ian Abbott
2019-04-10 6:21 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410062117.hy6az4zojslvtvfs@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=abbotti@mev.co.uk \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox