From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRXNx-0001EP-HS for barebox@lists.infradead.org; Fri, 17 May 2019 07:34:35 +0000 Date: Fri, 17 May 2019 09:34:31 +0200 From: Sascha Hauer Message-ID: <20190517073431.vpkic5gmi5guervb@pengutronix.de> References: <20190516091839.8504-1-s.trumtrar@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190516091839.8504-1-s.trumtrar@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] commands: spi: fix NULL pointer dereference To: Steffen Trumtrar Cc: Barebox List On Thu, May 16, 2019 at 11:18:39AM +0200, Steffen Trumtrar wrote: > The renaming of "master" to "controller" done in > 812a9ddcdf211302a050cf8f61f7af577bc29a23 > spi: Generalize SPI "master" to "controller" > > breaks the spi command, because the spi.master pointer is not assigned. > The pointer is kept for backwards compatability. > > Assign it, so that spi drivers that are still using "spi->master" can be > used. > > Signed-off-by: Steffen Trumtrar > --- > commands/spi.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox