From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT1Pf-0006LS-Fs for barebox@lists.infradead.org; Tue, 21 May 2019 09:50:29 +0000 Date: Tue, 21 May 2019 11:50:25 +0200 From: Sascha Hauer Message-ID: <20190521095025.i2kljfhh6j2tuhv5@pengutronix.de> References: <20190520182402.12753-1-andrew.smirnov@gmail.com> <20190520182402.12753-6-andrew.smirnov@gmail.com> <20190521093716.qywrzd2qvkrpcmwn@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190521093716.qywrzd2qvkrpcmwn@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 5/5] ARM: i.MX: Drop unused usb-imx6.c To: Andrey Smirnov Cc: barebox@lists.infradead.org On Tue, May 21, 2019 at 11:37:16AM +0200, Sascha Hauer wrote: > On Mon, May 20, 2019 at 11:24:02AM -0700, Andrey Smirnov wrote: > > Looks like usb-imx6.c was abandoned and there are no references to > > either of the functions difined there. Drop it. > > > > Signed-off-by: Andrey Smirnov > > --- > > arch/arm/mach-imx/Makefile | 2 +- > > arch/arm/mach-imx/usb-imx6.c | 111 ----------------------------------- > > 2 files changed, 1 insertion(+), 112 deletions(-) > > delete mode 100644 arch/arm/mach-imx/usb-imx6.c > > > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile > > index b86025cc3..b16de2866 100644 > > --- a/arch/arm/mach-imx/Makefile > > +++ b/arch/arm/mach-imx/Makefile > > @@ -10,7 +10,7 @@ obj-$(CONFIG_ARCH_IMX51) += imx51.o imx5.o > > pbl-$(CONFIG_ARCH_IMX51) += imx51.o imx5.o > > obj-$(CONFIG_ARCH_IMX53) += imx53.o imx5.o esdctl-v4.o > > pbl-$(CONFIG_ARCH_IMX53) += imx53.o imx5.o esdctl-v4.o > > -obj-$(CONFIG_ARCH_IMX6) += imx6.o usb-imx6.o > > +obj-$(CONFIG_ARCH_IMX6) += imx6.o > > CFLAGS_imx6.o := -march=armv7-a > > lwl-$(CONFIG_ARCH_IMX6) += imx6-mmdc.o > > obj-$(CONFIG_ARCH_IMX7) += imx7.o > > diff --git a/arch/arm/mach-imx/usb-imx6.c b/arch/arm/mach-imx/usb-imx6.c > > deleted file mode 100644 > > index 4236bcb77..000000000 > > --- a/arch/arm/mach-imx/usb-imx6.c > > +++ /dev/null > > @@ -1,111 +0,0 @@ > > - > > -int imx6_usb_phy2_disable_oc(void) > > -{ > > You leave the function prototypes in > arch/arm/mach-imx/include/mach/usb.h. Could you remove them aswell? Don't mind, I fixed this up while applying Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox