mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Mamonov <pmamonov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: use anonymous labels in ENTRY_FUNCTION_END and STOP_WITH_DEBUG_EVENT macros
Date: Tue, 4 Jun 2019 19:43:12 +0300	[thread overview]
Message-ID: <20190604164311.z5zo4qrfqbt5zalf@localhost.localdomain> (raw)
In-Reply-To: <20190604124457.25u3p7mgfvxrbqjh@pengutronix.de>

Hi, Oleksij,

On Tue, Jun 04, 2019 at 02:44:57PM +0200, Oleksij Rempel wrote:
> On Tue, Jun 04, 2019 at 01:55:52PM +0300, Peter Mamonov wrote:
> > Use of global labels of the same name inside ENTRY_FUNCTION_END and
> > STOP_WITH_DEBUG_EVENT prevents simultaneous use of both macros. It also
> > prevents multiple use of one of them.
> 
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> @Peter, Do you use STOP_WITH_DEBUG_EVENT for something?

Actually no. I hit this problem when tried to use ENTRY_FUNCTION_END twice to 
choose relevant DTB depending on some conditions.

Regards,
Peter

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-06-04 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 10:55 Peter Mamonov
2019-06-04 12:44 ` Oleksij Rempel
2019-06-04 16:43   ` Peter Mamonov [this message]
2019-06-05  5:17     ` Oleksij Rempel
2019-06-05 18:38       ` Peter Mamonov
2019-06-06  4:29         ` Oleksij Rempel
2019-06-06 19:22           ` Peter Mamonov
2019-06-07  6:29 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604164311.z5zo4qrfqbt5zalf@localhost.localdomain \
    --to=pmamonov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox