From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mvebu: make the compiler inline mvebu_remap_registers
Date: Fri, 7 Jun 2019 09:01:25 +0200 [thread overview]
Message-ID: <20190607070125.gbcemn5iurjbfrzh@pengutronix.de> (raw)
In-Reply-To: <20190605102356.5761-1-u.kleine-koenig@pengutronix.de>
On Wed, Jun 05, 2019 at 12:23:56PM +0200, Uwe Kleine-König wrote:
> Without that gcc 7.3.1 (from OSELAS.Toolchain-2018.02.0) makes
> mvebu_remap_registers a standalone function which in its prolog saves
> two registers to the stack. However this function is called early during
> startup when there is no stack available yet and sp still points into
> the nirvana which makes barebox crash.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-mvebu/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-mvebu/common.c b/arch/arm/mach-mvebu/common.c
> index 6b4fa8b889d1..5650c1ed8726 100644
> --- a/arch/arm/mach-mvebu/common.c
> +++ b/arch/arm/mach-mvebu/common.c
> @@ -188,7 +188,7 @@ mem_initcall(mvebu_meminit);
> #define MVEBU_BRIDGE_REG_BASE 0x20000
> #define DEVICE_INTERNAL_BASE_ADDR (MVEBU_BRIDGE_REG_BASE + 0x80)
>
> -static void mvebu_remap_registers(void)
> +static __always_inline void mvebu_remap_registers(void)
> {
> void __iomem *base = mvebu_get_initial_int_reg_base();
>
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-07 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 10:23 Uwe Kleine-König
2019-06-07 7:01 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607070125.gbcemn5iurjbfrzh@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox