From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-eopbgr680061.outbound.protection.outlook.com ([40.107.68.61] helo=NAM04-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcw1n-0007Lk-QG for barebox@lists.infradead.org; Mon, 17 Jun 2019 18:06:49 +0000 From: Cory Tusar Date: Mon, 17 Jun 2019 18:06:41 +0000 Message-ID: <20190617180636.GA21299@zii.aero> References: <20190614203438.18900-1-cory.tusar@zii.aero> <20190614203438.18900-2-cory.tusar@zii.aero> <20190617122123.m24jeihvqfxt7tpf@pengutronix.de> In-Reply-To: <20190617122123.m24jeihvqfxt7tpf@pengutronix.de> Content-Language: en-US Content-ID: <592E1816691D3D45A97C7527617E3F0A@namprd12.prod.outlook.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] common: boot: Instantiate storage for global.boot.machine_id To: Sascha Hauer Cc: "barebox@lists.infradead.org" , Chris Healy On Mon, Jun 17, 2019 at 02:21:23PM +0200, Sascha Hauer wrote: > On Fri, Jun 14, 2019 at 08:35:08PM +0000, Cory Tusar wrote: > > There are references throughout the documentation (and elsewhere in the > > boot code) regarding the use of machine-id in a bootloader spec file. > > However, there was no global storage allocated for this variable. > > > > This commit adds the necessary storage and associated initialization. > > > > Signed-off-by: Cory Tusar > > --- > > common/boot.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/common/boot.c b/common/boot.c > > index 974eaf5d0..fae2ff935 100644 > > --- a/common/boot.c > > +++ b/common/boot.c > > @@ -348,4 +348,13 @@ void bootsources_list(struct bootentries *bootentries) > > printf("%-20s %s\n", entry->title, entry->description); > > } > > > > +static int boot_init(void) > > +{ > > + globalvar_add_simple("boot.machine_id", NULL); > > + > > + return 0; > > +} > > +late_initcall(boot_init); > > There already is an initcall in this file adding a globalvar. Could you > add this change to the existing initcall and rename > init_boot_watchdog_timeout() to something more suitable? Will do. -Cory -- Cory Tusar Senior Software Engineer Zodiac Inflight Innovations 2929 E Imperial Hwy, Suite 170 Brea, CA 92821 (714) 203-0519 www.safran-aerosystems.com _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox