From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [RFC 0/2] MIPS: fix code relocation routine
Date: Thu, 20 Jun 2019 16:34:36 +0200 [thread overview]
Message-ID: <20190620143436.bwvwyoseqsvlrkb4@pengutronix.de> (raw)
In-Reply-To: <20190618093833.2005-1-antonynpavlov@gmail.com>
On Tue, Jun 18, 2019 at 12:38:31PM +0300, Antony Pavlov wrote:
> At the moment MIPS relocation code routine has at least two problems:
>
> 1. the first problem is fixed in the 'MIPS: relocate_code: fix barebox image size'
> patch from this patchseries.
>
> 2. relocate_code() calls flush_cache_all().
> flush_cache_all() uses 'struct cpuinfo_mips current_cpu_data' data fields.
> These data fields are initialized in r4k_cache_init().
>
> However in the current implementation the r4k_cache_init() function
> is called __AFTER__ relocate_code().
>
> This cache problem can't be discovered via qemu.
>
> Antony Pavlov (2):
> MIPS: lib/Makefile: fix whitespaces
> MIPS: relocate_code: fix barebox image memcpy() size
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-20 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 9:38 Antony Pavlov
2019-06-18 9:38 ` [RFC 1/2] MIPS: lib/Makefile: fix whitespaces Antony Pavlov
2019-06-18 9:38 ` [RFC 2/2] MIPS: relocate_code: fix barebox image memcpy() size Antony Pavlov
2019-06-18 11:05 ` Oleksij Rempel
2019-06-20 14:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620143436.bwvwyoseqsvlrkb4@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox