From: Sascha Hauer <s.hauer@pengutronix.de>
To: 张忠山 <zzs213@126.com>
Cc: barebox@lists.infradead.org
Subject: Re: bugfix: _barebox_image_size wrong if enable
Date: Wed, 26 Jun 2019 09:20:46 +0200 [thread overview]
Message-ID: <20190626072046.g23bh6kjpvgt2yhx@pengutronix.de> (raw)
In-Reply-To: <af35c2a1-420e-c2a4-0856-c6b667890a5e@126.com>
On Tue, Jun 18, 2019 at 06:17:52PM +0800, 张忠山 wrote:
> > No, it is corrected during runtime in relocate_to_current_adr(). It
> > seems older compilers need a runtime relocation fixup for this.
>
> Yes, in relocate_to_current_adr() the address all be fixed up.
>
> But if _barebox_image_size, __bss_start and __bss_stop all zero. the
> barebox_base calculated by arm_mem_barebox_image() would wrong. but because it
> align the base to 1M. So mostly it works fine. If the barebox size larger than
> 1M. It should fail.
>
> >
> > AFAIR this only happened for linker variables that point to absolute
> > addresses. Differences between addresses also worked with the older
> > compilers, and I think this is what your patch does:
>
> No. my patch just for new toolchain. with old toolchain it has no effect,
> Because all of the size is zero.
>
> By using the newer toolchain:
> arm-poky-eabi-gcc (GCC) 8.2.0
> GNU ld (GNU Binutils) 2.31.1.20180818
>
> In barebox config file:
> CONFIG_TEXT_BASE=0x23e00000
> CONFIG_RELOCATABLE=y
With CONFIG_RELOCATABLE enabled TEXT_BASE should be 0x0 and this should
be enforced by Kconfig dependencies. Which barebox version are you on
and which SoC are you compiling for?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-06-26 7:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 13:37 张忠山
2019-06-18 7:46 ` Sascha Hauer
2019-06-18 10:17 ` 张忠山
2019-06-24 3:37 ` 张忠山
2019-06-26 7:20 ` Sascha Hauer [this message]
2019-06-26 9:39 ` 张忠山
2019-06-27 10:30 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626072046.g23bh6kjpvgt2yhx@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=zzs213@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox