mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: rpi: use sdhost for eMMC access on CM3.
@ 2019-06-26  8:46 Tomaz Solc
  2019-06-27  9:07 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Tomaz Solc @ 2019-06-26  8:46 UTC (permalink / raw)
  To: barebox; +Cc: Tomaz Solc

This commit removes the fix for the upstream devicetree where eMMC was remapped
to the sdhci interface. This is no longer needed since sdhost driver is now
functional in barebox. A similar change was done to the R.Pi 3 devicetree in
9036d1db.

In fact, this remap prevented CM3 from booting if barebox was compiled with
CONFIG_MCI_BCM283X_SDHOST (in rpi_defconfig since b093468c). In that case both
sdhost and sdhci drivers were active and tried to set their corresponsing alt
functions for the same set of GPIOs at the same time.

Signed-off-by: Tomaz Solc <tomaz.solc@tablix.org>
---
 arch/arm/dts/bcm2837-rpi-cm3.dts | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm/dts/bcm2837-rpi-cm3.dts b/arch/arm/dts/bcm2837-rpi-cm3.dts
index cfbffe175..01c1f9a67 100644
--- a/arch/arm/dts/bcm2837-rpi-cm3.dts
+++ b/arch/arm/dts/bcm2837-rpi-cm3.dts
@@ -9,10 +9,3 @@
 		reg = <0x0 0x0>;
 	};
 };
-
-&sdhci {
-	pinctrl-0 = <&emmc_gpio48>;
-	no-sd;
-	non-removable;
-	status = "okay";
-};
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: rpi: use sdhost for eMMC access on CM3.
  2019-06-26  8:46 [PATCH] ARM: rpi: use sdhost for eMMC access on CM3 Tomaz Solc
@ 2019-06-27  9:07 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-06-27  9:07 UTC (permalink / raw)
  To: Tomaz Solc; +Cc: barebox

On Wed, Jun 26, 2019 at 10:46:49AM +0200, Tomaz Solc wrote:
> This commit removes the fix for the upstream devicetree where eMMC was remapped
> to the sdhci interface. This is no longer needed since sdhost driver is now
> functional in barebox. A similar change was done to the R.Pi 3 devicetree in
> 9036d1db.
> 
> In fact, this remap prevented CM3 from booting if barebox was compiled with
> CONFIG_MCI_BCM283X_SDHOST (in rpi_defconfig since b093468c). In that case both
> sdhost and sdhci drivers were active and tried to set their corresponsing alt
> functions for the same set of GPIOs at the same time.
> 
> Signed-off-by: Tomaz Solc <tomaz.solc@tablix.org>
> ---
>  arch/arm/dts/bcm2837-rpi-cm3.dts | 7 -------
>  1 file changed, 7 deletions(-)

Applied to master, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-27  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26  8:46 [PATCH] ARM: rpi: use sdhost for eMMC access on CM3 Tomaz Solc
2019-06-27  9:07 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox