From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1ho1qj-000587-LA for barebox@lists.infradead.org; Thu, 18 Jul 2019 08:33:15 +0000 Date: Thu, 18 Jul 2019 10:33:12 +0200 From: Roland Hieber Message-ID: <20190718083311.vhikec23phvx3lue@pengutronix.de> References: <20190717170604.23732-1-a.fatoum@pengutronix.de> <20190717170604.23732-5-a.fatoum@pengutronix.de> <20190718081955.cn7sctee7fx54lw2@pengutronix.de> <9efd3017-ce12-3e36-6ed3-41db8aa163ce@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9efd3017-ce12-3e36-6ed3-41db8aa163ce@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v3 4/6] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only To: Ahmad Fatoum Cc: Andrey Smirnov , barebox@lists.infradead.org On Thu, Jul 18, 2019 at 10:25:05AM +0200, Ahmad Fatoum wrote: > Hello Roland, > > On 18/7/19 10:19, Roland Hieber wrote: > > On Wed, Jul 17, 2019 at 07:06:02PM +0200, Ahmad Fatoum wrote: > >> From: Philipp Zabel > >> > >> Due to incorrect placement of the clock gate cell in the ldb_di[x]_clk > >> tree, the glitchy parent mux of ldb_di[x]_clk can cause a glitch to > >> enter the ldb_di_ipu_div divider. If the divider gets locked up, no > >> ldb_di[x]_clk is generated, and the LVDS display will hang when the > >> ipu_di_clk is sourced from ldb_di_clk. > >> > >> To fix the problem, both the new and current parent of the ldb_di_clk > >> should be disabled before the switch. As this can not be guaranteed by > >> the clock framework during runtime, make the ldb_di[x]_sel muxes read-only. > >> A workaround to set the muxes once during boot could be added to the > >> kernel or bootloader. > >> > >> Signed-off-by: Philipp Zabel > >> Signed-off-by: Fabio Estevam > >> Signed-off-by: Shawn Guo > >> [afa: reviewed for barebox] > >> Reviewed-by: Philipp Zabel > >> Tested-by: Andrey Smirnov > >> [afa: ported from Linux kernel commit 03d576f202] > > > > Should this line be further above, or were the lines above all part of > > the Linux commit? > > The first [afa: is the Demarcation line between kernel and barebox > commit message. If I moved the second [afa: further up it wouldn't be > that clear who did what.. Okay, until now I always read the footers like they were appended from top to bottom chronologically, so first reviewing it for barebox and only afterwards porting it from Linux doesn't make sense to me :-) I just haven't met your style in the wild yet. - Roland -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox