From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8IoT-0000fY-TM for barebox@lists.infradead.org; Thu, 12 Sep 2019 06:42:43 +0000 Date: Thu, 12 Sep 2019 08:42:40 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20190912064240.nyljjoqhgdharwk7@pengutronix.de> References: <20190909203451.13047-1-u.kleine-koenig@pengutronix.de> <20190909203451.13047-3-u.kleine-koenig@pengutronix.de> <20190912061617.guwsnwogkiya2y36@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190912061617.guwsnwogkiya2y36@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v4 2/2] mci: implement command to switch a mmc device to enhanced mode To: Sascha Hauer Cc: barebox@lists.infradead.org Hello, On Thu, Sep 12, 2019 at 08:16:17AM +0200, Sascha Hauer wrote: > On Mon, Sep 09, 2019 at 10:34:51PM +0200, Uwe Kleine-K=F6nig wrote: > > + ret =3D mci_send_ext_csd(mci, ext_csd); > > + if (ret) { > > + printf("Failure to read EXT_CSD register\n"); > > + free(ext_csd); > > + return ERR_PTR(-EIO); > > + } > > + > > + return ext_csd; > > +} > > + > > +/* enh_area -m [-c] /dev/mmcX */ > = > -m is not implemented > = > > +static int do_mmc_enh_area(int argc, char *argv[]) > > +{ > > + const char *devpath; > > + struct mci *mci; > > + u8 *ext_csd; > > + int set_completed =3D 0; > > + int opt; > > + int ret; > > + > > + while ((opt =3D getopt(argc, argv, "c")) > 0) { > > + switch (opt) { > > + case 'c': > > + set_completed =3D 1; > > + break; > > + } > > + } > > + > > + /* > > + * -m is currently mandatory to allow more flexible enhanced area > > + * specifications in the future. > > + */ > = > -m? -m was an intermediate step. You suggested to use -m instead of "setmax", but while implementing I noticed that with options there is no need for a keyword or option. Can you please squash this into my patch?: diff --git a/commands/mmc.c b/commands/mmc.c index b51522fce2a6..c696e7b8817b 100644 --- a/commands/mmc.c +++ b/commands/mmc.c @@ -80,7 +80,7 @@ static u8 *mci_get_ext_csd(struct mci *mci) return ext_csd; } = -/* enh_area -m [-c] /dev/mmcX */ +/* enh_area [-c] /dev/mmcX */ static int do_mmc_enh_area(int argc, char *argv[]) { const char *devpath; @@ -98,10 +98,6 @@ static int do_mmc_enh_area(int argc, char *argv[]) } } = - /* - * -m is currently mandatory to allow more flexible enhanced area - * specifications in the future. - */ if (argc - optind !=3D 1) { printf("Usage: mmc enh_area [-c] /dev/mmcX\n"); return COMMAND_ERROR_USAGE; or should I resend? Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox