From: Jules Maselbas <jmaselbas@kalray.eu>
To: barebox@lists.infradead.org
Cc: Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH 5/6] usb: string: size_t is unsigned
Date: Thu, 10 Oct 2019 10:15:02 +0200 [thread overview]
Message-ID: <20191010081503.15254-5-jmaselbas@kalray.eu> (raw)
In-Reply-To: <20191010081503.15254-1-jmaselbas@kalray.eu>
Testing if size_t is negative is not needed as size_t is unsigned.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/usb/core/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 5dc7993ac..e34cb5bf2 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -906,7 +906,7 @@ int usb_string(struct usb_device *dev, int index, char *buf, size_t size)
int err;
unsigned int u, idx;
- if (size <= 0 || !buf || !index)
+ if (!size || !buf || !index)
return -1;
buf[0] = 0;
tbuf = dma_alloc(USB_BUFSIZ);
--
2.21.0.196.g041f5ea
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-10 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 8:14 [PATCH 1/6] usb: hub: Use more accurate struct name Jules Maselbas
2019-10-10 8:14 ` [PATCH 2/6] usb: hub: Only clear port reset status if set Jules Maselbas
2019-10-10 8:15 ` [PATCH 3/6] usb: string: Use dma_alloc instead of a local buffer Jules Maselbas
2019-10-10 8:15 ` [PATCH 4/6] usb: string: Use le16_to_cpu for langid Jules Maselbas
2019-10-10 20:41 ` Andrey Smirnov
2019-10-14 11:42 ` Sascha Hauer
2019-10-14 15:09 ` Jules Maselbas
2019-10-10 8:15 ` Jules Maselbas [this message]
2019-10-10 8:15 ` [PATCH 6/6] usb: string: Minor changes Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010081503.15254-5-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox