From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] watchdog: add support for Fintek F718xx and, F818xx Super I/O
Date: Mon, 14 Oct 2019 14:39:30 +0200 [thread overview]
Message-ID: <20191014123930.x2ea4ka6hwu3u7uv@pengutronix.de> (raw)
In-Reply-To: <20191011162753.17100-3-a.fatoum@pengutronix.de>
On Fri, Oct 11, 2019 at 06:27:52PM +0200, Ahmad Fatoum wrote:
> This is an adaptation of the Linux v5.3 f71808e_wdt driver for the watchdog
> component of the Fintek Super I/O chips.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/watchdog/Kconfig | 10 +
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/f71808e_wdt.c | 379 +++++++++++++++++++++++++++++++++
> 3 files changed, 390 insertions(+)
> create mode 100644 drivers/watchdog/f71808e_wdt.c
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fbaab896d460..b1c2a39b6629 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -90,10 +90,20 @@ config STM32_IWDG_WATCHDOG
> Enable to support configuration of the STM32's on-SoC IWDG watchdog.
> Once started by the user, the IWDG can't be disabled.
>
> +
Please drop this hunk.
> config STPMIC1_WATCHDOG
> bool "STPMIC1 Watchdog"
> depends on MFD_STPMIC1
> help
> Enable to support configuration of the stpmic1's built-in watchdog.
>
> +config F71808E_WDT
> + bool "Fintek F718xx, F818xx Super I/O Watchdog"
> + depends on X86
> + select FINTEK_SUPERIO
I prefer a "depends on" here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-10-14 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:27 [PATCH 1/4] mfd: add basic Super I/O chip helpers Ahmad Fatoum
2019-10-11 16:27 ` [PATCH 2/4] mfd: superio: add Fintek MFD driver Ahmad Fatoum
2019-10-11 16:27 ` [PATCH 3/4] watchdog: add support for Fintek F718xx and, F818xx Super I/O Ahmad Fatoum
2019-10-14 12:39 ` Sascha Hauer [this message]
2019-10-14 12:47 ` [PATCH] fixup! " Ahmad Fatoum
2019-10-11 16:27 ` [PATCH 4/4] mfd: superio: add base SMSC MFD driver Ahmad Fatoum
2019-10-14 13:18 ` [PATCH 1/4] mfd: add basic Super I/O chip helpers Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014123930.x2ea4ka6hwu3u7uv@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox