From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] serial: efi-stdio: replace globals with handles in priv struct
Date: Wed, 23 Oct 2019 09:00:41 +0200 [thread overview]
Message-ID: <20191023070041.2dvdtmnql4z2cd4b@pengutronix.de> (raw)
In-Reply-To: <20191021092341.27633-1-a.fatoum@pengutronix.de>
On Mon, Oct 21, 2019 at 11:23:40AM +0200, Ahmad Fatoum wrote:
> Despite assigning efi_sys_table->{con_in,con_out} to priv->{in,out},
> some functions still use the global efi_sys_table->{con_in,con_out}.
> Let's restrict globals access to the probe function and have the priv
> struct completely describe input and output used in the callbacks.
> No functional change.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/serial/efi-stdio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-10-23 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 9:23 Ahmad Fatoum
2019-10-21 9:23 ` [PATCH 2/2] serial: efi-stdio: Add simple_text_input_ex_protocol backend Ahmad Fatoum
2019-10-23 7:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023070041.2dvdtmnql4z2cd4b@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox