From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4] libfile: copy_file: fix error handling
Date: Wed, 23 Oct 2019 09:16:51 +0200 [thread overview]
Message-ID: <20191023071651.mirbfgndknicuylq@pengutronix.de> (raw)
In-Reply-To: <1571752052-101565-1-git-send-email-r.karszniewicz@phytec.de>
On Tue, Oct 22, 2019 at 03:47:32PM +0200, Robert Karszniewicz wrote:
> Before this, ret was falsely polluted, which caused a misleading error
> message if the function bailed out at a later point.
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---
> lib/libfile.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-10-23 7:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:59 [PATCH] libfile: copy_file: prevent spurious error message Robert Karszniewicz
2019-10-16 11:26 ` [PATCH v2] " Robert Karszniewicz
2019-10-18 11:45 ` Sascha Hauer
2019-10-18 17:10 ` [PATCH v3] " Robert Karszniewicz
2019-10-18 17:15 ` Robert Karszniewicz
2019-10-21 7:37 ` Sascha Hauer
2019-10-22 13:47 ` [PATCH v4] libfile: copy_file: fix error handling Robert Karszniewicz
2019-10-23 7:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023071651.mirbfgndknicuylq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.karszniewicz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox