From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOrmn-00053d-7v for barebox@lists.infradead.org; Sun, 27 Oct 2019 23:17:26 +0000 From: Ahmad Fatoum Date: Mon, 28 Oct 2019 00:16:40 +0100 Message-Id: <20191027231647.9884-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: rom 3eed5e64521bacd6f8e84326aa98db7402ffc6fd Mon Sep 17 00:00:00 2001 To: barebox@lists.infradead.org Cc: F@pengutronix.de, Ahmad Fatoum mode and alt are printed with the dev_dbg before they are initialized. Remedy this by moving the dev_dbg after them. Signed-off-by: Ahmad Fatoum --- drivers/pinctrl/pinctrl-stm32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-stm32.c b/drivers/pinctrl/pinctrl-stm32.c index 7f04cea50b75..ab121998a37f 100644 --- a/drivers/pinctrl/pinctrl-stm32.c +++ b/drivers/pinctrl/pinctrl-stm32.c @@ -157,13 +157,13 @@ static int stm32_pinctrl_set_state(struct pinctrl_device *pdev, struct device_no if (offset < 0) return -ENODEV; + mode = stm32_gpio_get_mode(func); + alt = stm32_gpio_get_alt(func); + dev_dbg(pdev->dev, "configuring port %s pin %u with:\n\t" "fn %u, mode %u, alt %u\n", bank->name, offset, func, mode, alt); - mode = stm32_gpio_get_mode(func); - alt = stm32_gpio_get_alt(func); - clk_enable(bank->clk); __stm32_pmx_set_mode(bank->base, offset, mode, alt); -- 2.23.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox