From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSHmc-0002gw-JJ for barebox@lists.infradead.org; Wed, 06 Nov 2019 09:39:24 +0000 Date: Wed, 6 Nov 2019 10:39:20 +0100 From: Sascha Hauer Message-ID: <20191106093920.pv63rmdl43czn74j@pengutronix.de> References: <20191106071155.26389-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191106071155.26389-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 01/10] commands: regulator: move implementation to regulator core To: Ahmad Fatoum Cc: barebox@lists.infradead.org, mgr@pengutronix.de On Wed, Nov 06, 2019 at 08:11:46AM +0100, Ahmad Fatoum wrote: > In preparation for teaching the regulator command how to enable and > disable regulators, move the regulator command implementation to the > regulator core, so the internal interfaces for iterating through the > list of available regulators can be more easily used. No. Please leave the command code where it is. When you need a regulator_by_name() function then implement it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox