mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] net: cpsw: don't reset twice
Date: Fri, 15 Nov 2019 17:19:28 +0100	[thread overview]
Message-ID: <20191115161928.12313-1-m.grzeschik@pengutronix.de> (raw)

The softreset was already called previously in open and other settings
have been prepared afterwards, so don't reset it a second time.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 drivers/net/cpsw.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
index b9a6575009..4eb2205daa 100644
--- a/drivers/net/cpsw.c
+++ b/drivers/net/cpsw.c
@@ -676,8 +676,6 @@ static void cpsw_slave_init(struct cpsw_slave *slave, struct cpsw_priv *priv)
 
 	dev_dbg(&slave->dev, "* %s\n", __func__);
 
-	soft_reset(priv, &slave->sliver->soft_reset);
-
 	/* setup priority mapping */
 	writel(0x76543210, &slave->sliver->rx_pri_map);
 	writel(0x33221100, &slave->regs->tx_pri_map);
-- 
2.24.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2019-11-15 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 16:19 Michael Grzeschik [this message]
2019-11-18  8:16 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115161928.12313-1-m.grzeschik@pengutronix.de \
    --to=m.grzeschik@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox