mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Du Huanpeng <u74147@gmail.com>
Cc: barebox@lists.infradead.org, Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH] MIPS: Makefile: minor codingstyle fix
Date: Mon, 25 Nov 2019 09:40:36 +0100	[thread overview]
Message-ID: <20191125084036.p7akxlzumpieod7u@pengutronix.de> (raw)
In-Reply-To: <20191122115700.GA15570@brew>

On Fri, Nov 22, 2019 at 07:57:03PM +0800, Du Huanpeng wrote:
> Hi.
> 
> > Actually all of this lines haw incorrect coding style. It should be 80
> > char width style.
> I see this, but it is more practical here. the editor will automatic warp lines.
> 
> I can write a better description and send a v2 patch.

Please do so. Please don't take 80 chars as a hard limit. While I think
the lines we are talking about here are a bit long, forcing it to 80
chars doesn't really improve readability.

i.e the following looks good, eventhough it's longer than 80 chars:

cflags-$(CONFIG_CPU_LOONGSON1) += \
	$(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
	-Wa,-mips32r2 -Wa,--trap

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-11-25  8:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22  8:34 Du Huanpeng
2019-11-22  9:08 ` Oleksij Rempel
2019-11-22  9:46   ` Tim Williams
2019-11-22 11:11     ` Oleksij Rempel
2019-11-22 11:57       ` Du Huanpeng
2019-11-25  8:40         ` Sascha Hauer [this message]
2019-11-26  7:12 Du Huanpeng
2019-11-27  1:07 Du Huanpeng
2019-11-27  5:22 ` Oleksij Rempel
2019-11-27  5:58   ` Du Huanpeng
2019-11-27 14:02 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125084036.p7akxlzumpieod7u@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    --cc=u74147@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox