mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] scripts: imx: report file where error occurred
Date: Mon, 2 Dec 2019 09:59:00 +0100	[thread overview]
Message-ID: <20191202085900.6joqgplkyqtt2si7@pengutronix.de> (raw)
In-Reply-To: <20191128163707.6055-1-a.fatoum@pengutronix.de>

On Thu, Nov 28, 2019 at 05:37:08PM +0100, Ahmad Fatoum wrote:
> Especially when using #include directives in imxcfg files, error
> messages can be hard to follow because line numbers differ between
> preprocessor and source files. Teach the imx image generation tool about
> preprocessing line number / file name directive, so it can give more
> useful error messages. Instead of:
> 
>   error in line 11: Invalid argument
> 
> It now says:
> 
>   $barebox/arch/arm/boards/$som/flash-header-$board.imxcfg:5: Invalid argument
> 
> No change in compiled barebox binaries.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-12-02  8:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 16:37 Ahmad Fatoum
2019-12-02  8:59 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202085900.6joqgplkyqtt2si7@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox