From: Sascha Hauer <s.hauer@pengutronix.de>
To: Stefan Riedmueller <s.riedmueller@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: phycore: Remove emmc vmmc-supply
Date: Thu, 5 Dec 2019 09:07:55 +0100 [thread overview]
Message-ID: <20191205080755.nc2ao3hjb5eli7ud@pengutronix.de> (raw)
In-Reply-To: <1575380921-160915-1-git-send-email-s.riedmueller@phytec.de>
Hi Stefan,
On Tue, Dec 03, 2019 at 02:48:41PM +0100, Stefan Riedmueller wrote:
> There is no driver for the eMMC's vmmc-supply regulator in the barebox.
> Use a dummy regulator instead by simply deleting the vmmc-supply
> property.
>
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> ---
> arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> index 69f252b42382..974e271f453d 100644
> --- a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -112,6 +112,7 @@
> };
>
> &usdhc4 {
> + /delete-property/ vmmc-supply;
I don't like this approach very much. It's fine for barebox, but leads
to problems once you start Linux with the barebox device tree. I'd
rather go with the unmodified device trees (apart from the things
barebox changes to the device trees in order to start Linux).
One idea that comes to my mind is: Would it be possible to provide a
call like
int regulator_provide_dummy(struct device_node *np);
Boards could call this to let barebox provide a dummy regulator for the
given node (the "dlg,da9062" node in your case) and its child nodes.
In of_regulator_get() we then see if the desired regulator is a child
node of a node registered as dummy provider, then register a dummy
regulator and return it.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-12-05 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 13:48 Stefan Riedmueller
2019-12-05 8:07 ` Sascha Hauer [this message]
2019-12-05 8:37 ` Ahmad Fatoum
2019-12-05 13:08 ` Stefan Riedmüller
2019-12-05 13:31 ` Ahmad Fatoum
2019-12-06 14:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205080755.nc2ao3hjb5eli7ud@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.riedmueller@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox