From: Sascha Hauer <s.hauer@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] image-metadata: add flags field to imd_header
Date: Mon, 9 Dec 2019 12:39:38 +0100 [thread overview]
Message-ID: <20191209113938.nmm6vyges7dxpbzg@pengutronix.de> (raw)
In-Reply-To: <20191209104238.31161-2-s.trumtrar@pengutronix.de>
On Mon, Dec 09, 2019 at 11:42:36AM +0100, Steffen Trumtrar wrote:
> To allow marking an imd tag with properties, add a flags field to the imd_header.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> include/image-metadata.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/image-metadata.h b/include/image-metadata.h
> index 5904d95acd37..ca73e6cf6ec6 100644
> --- a/include/image-metadata.h
> +++ b/include/image-metadata.h
> @@ -28,6 +28,8 @@
> #define IMD_TYPE_END 0x640c7fff
> #define IMD_TYPE_INVALID 0xffffffff
>
> +#define IMD_FLAG_TAG_VALID (1 << 0)
> +
> /*
> * The IMD header. All data is stored in little endian format in the image.
> * The next header starts at the next 4 byte boundary after the data.
> @@ -35,6 +37,7 @@
> struct imd_header {
> uint32_t type; /* One of IMD_TYPE_* above */
> uint32_t datalength; /* Length of the data (exluding the header) */
> + uint32_t flags;
> };
Erm, no. struct imd_header shouldn't be changed, this breaks the imd
tool. What I meant is that the valid flag should be added to the crc
tag.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-12-09 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 10:42 [PATCH v2 1/4] imd: replace magicvalue with sizeof(struct) Steffen Trumtrar
2019-12-09 10:42 ` [PATCH v2 2/4] image-metadata: add flags field to imd_header Steffen Trumtrar
2019-12-09 11:39 ` Sascha Hauer [this message]
2019-12-09 10:42 ` [PATCH v2 3/4] imd: add support for checksum generation/verification Steffen Trumtrar
2019-12-09 10:42 ` [PATCH v2 4/4] commands: bbu: add support for imd checksum Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209113938.nmm6vyges7dxpbzg@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox