Re: [PATCH v2] firmware: zynqmp-fpga: drop example bin format header

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Dec 10, 2019 at 12:38:33PM +0100, Michael Tretter wrote:
> Avoid the example bitstream header to validate the bitstream that should
> be loaded into the FPGA. The header is mostly 0xFFFFFFFF with a few
> special values at a certain offsets and can be better described with the
> offsets and their magic values.
> 
> As a drive by, this fixes/removes a broken check in the header
> validation. The != operator has a higher precedence than ?: and this
> check should have had parenthesis around the ?: expression:
> 
> 	bin_header[i] != (byte_order == XILINX_BYTE_ORDER_BIT) ?
>               bin_format[i] : __swab32(bin_format[i])
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> Reviewed-by: Thomas Haemmerle <thomas.haemmerle@wolfvision.net>
> ---
> Changes in v2:
>  - Fix subject zynmp-fpga -> zynqmp-fpga
> 
>  drivers/firmware/zynqmp-fpga.c | 121 +++++++++++++++++----------------
>  1 file changed, 62 insertions(+), 59 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox