From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Marcin Niestrój" <m.niestroj@grinn-global.com>
Cc: Maik Otto <m.otto@phytec.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v2] habv4: imx change signing area from full to the executed image
Date: Mon, 6 Jan 2020 10:35:03 +0100 [thread overview]
Message-ID: <20200106093503.v4kftjlk3p5u6ut2@pengutronix.de> (raw)
In-Reply-To: <87imm8huub.fsf@grinn-global.com>
On Sun, Dec 22, 2019 at 11:13:48PM +0100, Marcin Niestrój wrote:
> Hi Sasha, Maik,
>
> Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> > On Wed, Dec 18, 2019 at 01:57:17PM +0100, Maik Otto wrote:
> >> the whole barebox with mbr and partition table were be signed by default.
> >> change the signing to the executed image without signing the mbr,
> >> partition table and header_gap by imx8mq
> >> additional delete option full, from-dcdofs and skip-mbr
> >>
> >> Signed-off-by: Maik Otto <m.otto@phytec.de>
> >> ---
> >> Changes in v2:
> >> - change subject from habv4: add the possibility to changing the signing
> >> area from Kconfig to
> >> - delete KConfig entries
> >> - delete changes habv4-imx6-gencsf.h
> >> - delete full, from-dcdofs and skip-mbr options
> >> ---
> >> scripts/imx/imx.c | 33 +++++++++------------------------
> >> 1 file changed, 9 insertions(+), 24 deletions(-)
> >
> > Applied, thanks.
> >
> > @Marcin, as you introduced the "from-dcdofs" and "full" options, are you
> > happy with this patch? It removes the options, but should default to
> > what you originally wanted to archieve, right?
>
> I think that when adding separate skip-mbr and from-dcdofs I wanted to
> protect (with skip-mbr) first bytes of generated image, which contain
> barebox header (with its version?) from what I remember. I never used
> that information from there, so I am quite okay with dropping skip-mbr
> support in favor of only from-dcdofs.
The version is not contained in the header.
>
> However I wonder why offset_load_address is hardcoded to
> 0x400. Shouldn't we leave from-dcdofs as is and simply dropping all
> other options (full and skip-mbr)?
Yes, this sounds better. Maik, can you change the patch accordingly?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-06 9:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 12:57 Maik Otto
2019-12-20 15:24 ` Sascha Hauer
2019-12-22 22:13 ` Marcin Niestrój
2020-01-06 9:35 ` Sascha Hauer [this message]
2020-01-06 14:42 ` Maik Otto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106093503.v4kftjlk3p5u6ut2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.niestroj@grinn-global.com \
--cc=m.otto@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox