[PATCH] imx25: drop global over-current setting for USB

[PATCH] imx25: drop global over-current setting for USB

[Uwe Kleine-König]

There is no mx25 board in mainline that actually uses USB. My
(out-of-tree) board has active low polarity which makes it necessary to
have

	/delete-property/ over-current-active-high;
	over-current-active-low;

in the board's dts which is ugly.

In the absence of this property Linux defaults to active-high and
encourages explicit configuration (see commit 1bf4743f641d ("usb:
chipidea: imx: Warn if oc polarity isn't specified")), so other external
board dts files likely already have this setting anyhow. (OK, maybe a
bit optimistic here :-)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/dts/imx25.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/dts/imx25.dtsi b/arch/arm/dts/imx25.dtsi
index e72dbd5f3686..05678af71aae 100644
--- a/arch/arm/dts/imx25.dtsi
+++ b/arch/arm/dts/imx25.dtsi
@@ -24,11 +24,3 @@
 &usbmisc {
 	status = "okay";
 };
-
-&usbotg {
-	over-current-active-high;
-};
-
-&usbhost1 {
-	over-current-active-high;
-};
-- 
2.24.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] imx25: drop global over-current setting for USB

[Sascha Hauer]

On Wed, Jan 15, 2020 at 11:33:28AM +0100, Uwe Kleine-König wrote:
> There is no mx25 board in mainline that actually uses USB. My
> (out-of-tree) board has active low polarity which makes it necessary to
> have
> 
> 	/delete-property/ over-current-active-high;
> 	over-current-active-low;
> 
> in the board's dts which is ugly.
> 
> In the absence of this property Linux defaults to active-high and
> encourages explicit configuration (see commit 1bf4743f641d ("usb:
> chipidea: imx: Warn if oc polarity isn't specified")), so other external
> board dts files likely already have this setting anyhow. (OK, maybe a
> bit optimistic here :-)
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/dts/imx25.dtsi | 8 --------
>  1 file changed, 8 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox