From: Jules Maselbas <jmaselbas@kalray.eu>
To: Barebox List <barebox@lists.infradead.org>
Cc: Jules Maselbas <jmaselbas@kalray.eu>
Subject: [PATCH v2 6/7] usb: dwc2: host: Fix toggle reset
Date: Wed, 22 Jan 2020 16:49:07 +0100 [thread overview]
Message-ID: <20200122154908.22635-7-jmaselbas@kalray.eu> (raw)
In-Reply-To: <20200122154908.22635-1-jmaselbas@kalray.eu>
From USB 2.0 specification, section 9.4.5:
ClearFeature(ENDPOINT_HALT) request always results in
the data toggle being reinitialized to DATA0.
The hacky solution for now is to reset the toggle bit to DATA0 when
the host controller send a ClearFeature request on an endpoint.
Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
drivers/usb/dwc2/host.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/usb/dwc2/host.c b/drivers/usb/dwc2/host.c
index 5be101752..e6344ea41 100644
--- a/drivers/usb/dwc2/host.c
+++ b/drivers/usb/dwc2/host.c
@@ -372,7 +372,23 @@ int dwc2_submit_control_msg(struct usb_device *udev,
if (ret)
return ret;
+ if (setup->requesttype == USB_RECIP_ENDPOINT
+ && setup->request == USB_REQ_CLEAR_FEATURE) {
+ /* From USB 2.0, section 9.4.5:
+ * ClearFeature(ENDPOINT_HALT) request always results
+ * in the data toggle being reinitialized to DATA0.
+ */
+ int ep = usb_pipeendpoint(pipe);
+ int data0 = TSIZ_SC_MC_PID_DATA0;
+
+ if (usb_pipein(pipe))
+ dwc2->in_data_toggle[devnum][ep] = data0;
+ else
+ dwc2->out_data_toggle[devnum][ep] = data0;
+ }
+
udev->act_len = act_len;
+ udev->status = 0;
return 0;
}
--
2.21.0.196.g041f5ea
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-22 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:49 [PATCH v2 0/7] usb: dwc2 host driver Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 1/7] usb: dwc2: Add host controller driver Jules Maselbas
2020-01-24 14:32 ` Sascha Hauer
2020-01-27 17:23 ` Jules Maselbas
2020-01-28 8:01 ` Sascha Hauer
2020-01-22 15:49 ` [PATCH v2 2/7] usb: dwc2: host: Read dr_mode from device tree Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 3/7] usb: dwc2: host: Rework roothub interface Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 4/7] usb: dwc2: host: Handle dma mapping errors Jules Maselbas
2020-01-22 15:49 ` [PATCH v2 5/7] usb: dwc2: host: Dynamic fifo size support from Linux Jules Maselbas
2020-01-22 15:49 ` Jules Maselbas [this message]
2020-01-22 15:49 ` [PATCH v2 7/7] usb: dwc2: host: Rewrite dwc2_hc_init Jules Maselbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122154908.22635-7-jmaselbas@kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox