* [PATCH] barebox_banner: switch to pr_notice
@ 2020-01-27 7:46 Christian Eggers
2020-01-28 9:33 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Christian Eggers @ 2020-01-27 7:46 UTC (permalink / raw)
To: barebox; +Cc: Christian Eggers, ceggers
The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
can be disabled.
Fixes: 1d60b224e5 ("barebox_banner: switch to pr_info")
Signed-off-by: Christian Eggers <ceggers@arri.de>
---
common/version.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/version.c b/common/version.c
index 8b1fd4dbe..0457b37a7 100644
--- a/common/version.c
+++ b/common/version.c
@@ -14,8 +14,8 @@ EXPORT_SYMBOL(release_string);
void barebox_banner (void)
{
printf("\n\n");
- pr_info("%s", version_string);
+ pr_notice("%s", version_string);
printf("\n\n");
- pr_info("Board: %s\n", barebox_get_model());
+ pr_notice("Board: %s\n", barebox_get_model());
}
#endif
--
Christian Eggers
Embedded software developer
Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] barebox_banner: switch to pr_notice
2020-01-27 7:46 [PATCH] barebox_banner: switch to pr_notice Christian Eggers
@ 2020-01-28 9:33 ` Sascha Hauer
2020-01-28 9:39 ` [SPAM:54%] " Christian Eggers
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2020-01-28 9:33 UTC (permalink / raw)
To: Christian Eggers; +Cc: barebox, ceggers
On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> can be disabled.
With that argument you could put it in any loglevel you want to.
>
> Fixes: 1d60b224e5 ("barebox_banner: switch to pr_info")
I wouldn't consider the current behaviour being broken, just different.
I am fine with the patch, but can we reword to something like "print
important message on higher loglevel?
Sascha
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> common/version.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/version.c b/common/version.c
> index 8b1fd4dbe..0457b37a7 100644
> --- a/common/version.c
> +++ b/common/version.c
> @@ -14,8 +14,8 @@ EXPORT_SYMBOL(release_string);
> void barebox_banner (void)
> {
> printf("\n\n");
> - pr_info("%s", version_string);
> + pr_notice("%s", version_string);
> printf("\n\n");
> - pr_info("Board: %s\n", barebox_get_model());
> + pr_notice("Board: %s\n", barebox_get_model());
> }
> #endif
> --
> Christian Eggers
> Embedded software developer
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [SPAM:54%] Re: [PATCH] barebox_banner: switch to pr_notice
2020-01-28 9:33 ` Sascha Hauer
@ 2020-01-28 9:39 ` Christian Eggers
2020-01-28 9:59 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Christian Eggers @ 2020-01-28 9:39 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox, ceggers
Am Dienstag, 28. Januar 2020, 10:33:19 CET schrieb Sascha Hauer:
> On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> > The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> > to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> > can be disabled.
>
> With that argument you could put it in any loglevel you want to.
that's right. Do you like to insert the highest possible log level for this
particular case?
> I am fine with the patch, but can we reword to something like "print
> important message on higher loglevel?
Yes, of course. Do you like a new patch or would you change this yourself?
regards
Christian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [SPAM:54%] Re: [PATCH] barebox_banner: switch to pr_notice
2020-01-28 9:39 ` [SPAM:54%] " Christian Eggers
@ 2020-01-28 9:59 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2020-01-28 9:59 UTC (permalink / raw)
To: Christian Eggers; +Cc: barebox, ceggers
On Tue, Jan 28, 2020 at 10:39:10AM +0100, Christian Eggers wrote:
> Am Dienstag, 28. Januar 2020, 10:33:19 CET schrieb Sascha Hauer:
> > On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> > > The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> > > to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> > > can be disabled.
> >
> > With that argument you could put it in any loglevel you want to.
> that's right. Do you like to insert the highest possible log level for this
> particular case?
In that case we would get a big red "EMERG: barebox 2020..." message. I
just see that this already starts with pr_notice which now with this
patch prints "NOTICE: barebox 2020...". Hm, I don't think this is what
we want.
You probably have CONFIG_CONSOLE_ALLOW_COLOR disabled so you don't see
that.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-28 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 7:46 [PATCH] barebox_banner: switch to pr_notice Christian Eggers
2020-01-28 9:33 ` Sascha Hauer
2020-01-28 9:39 ` [SPAM:54%] " Christian Eggers
2020-01-28 9:59 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox