From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [RFC PATCH 9/9] usb: dwc2: Add gadget driver
Date: Mon, 27 Jan 2020 14:40:34 +0100 [thread overview]
Message-ID: <20200127134034.nnlluowtpbel5kmp@pengutronix.de> (raw)
In-Reply-To: <20200122154950.22746-10-jmaselbas@kalray.eu>
Hi Jules,
On Wed, Jan 22, 2020 at 04:49:50PM +0100, Jules Maselbas wrote:
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
> drivers/usb/dwc2/Makefile | 2 +-
> drivers/usb/dwc2/core.h | 8 +-
> drivers/usb/dwc2/dwc2.c | 2 +
> drivers/usb/dwc2/dwc2.h | 2 +
> drivers/usb/dwc2/gadget.c | 2668 +++++++++++++++++++++++++++++++++++++
> drivers/usb/dwc2/regs.h | 1 +
> 6 files changed, 2681 insertions(+), 2 deletions(-)
> create mode 100644 drivers/usb/dwc2/gadget.c
>
+
> +int dwc2_gadget_init(struct dwc2 *dwc2)
> +{
> + u32 dctl;
> + int epnum;
> + int ret;
> +
> + dwc2_core_init(dwc2);
This is called once during probe here and once during host init, it
should probably only be called once.
I would expect both host and gadget support to be optional, but instead
both is unconditionally compiled in. Does this link when USB host or gadget
support is disabled?
How does the driver select between host and gadget mode? Normally we do
not have any real OTG support in barebox. With dr_mode = "otg" in the
device tree we usually register some device which the user can use to
specify the mode during runtime. How is this solved here?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-27 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:49 [RFC PATCH 0/9] usb: Add dwc2 " Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 1/9] BACKPORT: usb: Add helper to extract bits 12:11 of wMaxPacketize Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 2/9] BACKPORT: usb: ch9: make usb_endpoint_maxp() return only packet size Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 3/9] usb: Update uses of usb_endpoint_maxp Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 4/9] usb: dwc2: Add otg state Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 5/9] usb: dwc2: Add function to flush a tx fifo Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 6/9] usb: dwc2: Add structure for gadget driver Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 7/9] usb: dwc2: Add getter for gadget fifo hwparams Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 8/9] usb: dwc2: gadget: Configure fifo size Jules Maselbas
2020-01-22 15:49 ` [RFC PATCH 9/9] usb: dwc2: Add gadget driver Jules Maselbas
2020-01-27 13:40 ` Sascha Hauer [this message]
2020-01-27 17:18 ` Jules Maselbas
2020-01-28 8:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127134034.nnlluowtpbel5kmp@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox