From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Eggers <ceggers@arri.de>
Cc: barebox@lists.infradead.org, ceggers@gmx.de
Subject: Re: [PATCH] barebox_banner: switch to pr_notice
Date: Tue, 28 Jan 2020 10:33:19 +0100 [thread overview]
Message-ID: <20200128093319.riamlkm6ihgoh7c2@pengutronix.de> (raw)
In-Reply-To: <20200127074606.17254-1-ceggers@arri.de>
On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> can be disabled.
With that argument you could put it in any loglevel you want to.
>
> Fixes: 1d60b224e5 ("barebox_banner: switch to pr_info")
I wouldn't consider the current behaviour being broken, just different.
I am fine with the patch, but can we reword to something like "print
important message on higher loglevel?
Sascha
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> common/version.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/version.c b/common/version.c
> index 8b1fd4dbe..0457b37a7 100644
> --- a/common/version.c
> +++ b/common/version.c
> @@ -14,8 +14,8 @@ EXPORT_SYMBOL(release_string);
> void barebox_banner (void)
> {
> printf("\n\n");
> - pr_info("%s", version_string);
> + pr_notice("%s", version_string);
> printf("\n\n");
> - pr_info("Board: %s\n", barebox_get_model());
> + pr_notice("Board: %s\n", barebox_get_model());
> }
> #endif
> --
> Christian Eggers
> Embedded software developer
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
> Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
> Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-28 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:46 Christian Eggers
2020-01-28 9:33 ` Sascha Hauer [this message]
2020-01-28 9:39 ` [SPAM:54%] " Christian Eggers
2020-01-28 9:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128093319.riamlkm6ihgoh7c2@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ceggers@arri.de \
--cc=ceggers@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox