mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org, Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [PATCH v1] MIPS: remove .bss to __rel_start overlay
Date: Tue, 28 Jan 2020 17:42:31 +0300	[thread overview]
Message-ID: <20200128174231.c17bdeb1b67df64a466bb34c@gmail.com> (raw)
In-Reply-To: <5bcf8c57-1e42-44fa-1681-4bb1cafa5d88@pengutronix.de>

On Tue, 28 Jan 2020 14:53:07 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Note:
> memtest on ar9331 works only with this patch:
> 
> diff --git a/arch/mips/lib/cpu-probe.c b/arch/mips/lib/cpu-probe.c
> index cbde43a595..0d2dcf8b03 100644
> --- a/arch/mips/lib/cpu-probe.c
> +++ b/arch/mips/lib/cpu-probe.c
> @@ -177,6 +177,9 @@ static int mips_request_stack(void)
>          if (!request_sdram_region("stack", mips_stack_top - STACK_SIZE, STACK_SIZE))
>                  pr_err("Error: Cannot request SDRAM region for stack\n");
> 
> +       if (!request_sdram_region("vector", 0x80000000, 0x8000))
> +               pr_err("Error: Cannot request SDRAM region for vector\n");
> +
>          return 0;
>   }
>   coredevice_initcall(mips_request_stack);


Can we put this request_sdram_region() into main_entry.c to keep it close to trap_init?
Thereby we have a change to reuse ebase value instead of the 0x80000000 magic constant.
Also 0x8000 size is too large. See MIPS Run, 2nd Edition by Dominic Sweetman states 
general exception entry point is BASE+0x180 (used by barebox), and Interrupt Special
starts at BASE+0x200 (not used by barebox), so 0x200 is just enough.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-01-28 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28  9:28 Oleksij Rempel
2020-01-28 11:55 ` Antony Pavlov
2020-01-28 12:39   ` Oleksij Rempel
2020-01-28 13:06   ` Peter Mamonov
2020-01-28 13:43     ` Oleksij Rempel
2020-01-28 13:53       ` Oleksij Rempel
2020-01-28 14:42         ` Antony Pavlov [this message]
2020-01-28 12:54 ` Antony Pavlov
2020-01-28 13:39   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128174231.c17bdeb1b67df64a466bb34c@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pmamonov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox