From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix4hQ-0003JR-2T for barebox@lists.infradead.org; Thu, 30 Jan 2020 07:57:17 +0000 Date: Thu, 30 Jan 2020 08:57:12 +0100 From: Sascha Hauer Message-ID: <20200130075712.icgvhv53wpqsg4j2@pengutronix.de> References: <20200127155013.4388-1-m.grzeschik@pengutronix.de> <20200127155013.4388-2-m.grzeschik@pengutronix.de> <20200128084550.uxe7hn2qlvcik5tz@pengutronix.de> <20200129221920.g2ercgyrxmu62gc3@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200129221920.g2ercgyrxmu62gc3@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/4] regulator: pfuze: add support to other architectures To: Michael Grzeschik Cc: barebox@lists.infradead.org On Wed, Jan 29, 2020 at 11:19:20PM +0100, Michael Grzeschik wrote: > Hi Sascha, > > On Tue, Jan 28, 2020 at 09:45:50AM +0100, Sascha Hauer wrote: > > Hi Michael, > > > > On Mon, Jan 27, 2020 at 04:50:11PM +0100, Michael Grzeschik wrote: > > > Currently the pfuze driver is build dependent to ARCH_IMX6. To make it > > > possible to work with ARCH_IMX8 we move the imx6_poweroff call to an own > > > poweroff handler. > > > > > > Signed-off-by: Michael Grzeschik > > > --- > > > arch/arm/mach-imx/imx6.c | 8 ++++++++ > > > drivers/regulator/Kconfig | 2 +- > > > drivers/regulator/pfuze.c | 2 -- > > > 3 files changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c > > > index 41e0066add..8f1638c1ea 100644 > > > --- a/arch/arm/mach-imx/imx6.c > > > +++ b/arch/arm/mach-imx/imx6.c > > > @@ -401,3 +401,11 @@ void __noreturn imx6_pm_stby_poweroff(void) > > > > > > while(1); > > > } > > > + > > > +static int imx6_init(void) > > > +{ > > > + poweroff_handler_register_fn(imx6_pm_stby_poweroff); > > > + > > > + return 0; > > > +} > > > > imx6_pm_stby_poweroff() only works when a pfuze is present and is > > configured correctly. Calling this on every i.MX board is not nice. > > Right > > > What you can do is to call pfuze_register_init_callback() from here. > > You'll have to add a static inline wrapper for this in case pfuze > > support is not compiled in. > > So you mean, call pfuze_register_init_callback to register a callback > function which then itself registers the poweroff_handler as above? > > I think that could work, but then the init_callback is already used for > every imx6. The callback would also be overwritten by users in board > code trying to preconfigure the pfuze into a sane state, right? Yes. Board code would then have to call imx6_pm_stby_poweroff() additionally to its own fixups. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox