[PATCH 1/2] driver: bail out, don't crash, if drv->name is not set

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Currently, we expect each driver to have a name. If a driver doesn't,
we run into a NULL pointer dereference. Make this error scenario more
pleasant by checking if a name is set and failing otherwise.

The only in-tree driver affected by this is drivers/watchdog/dw_wdt.c,
which will be fixed in the follow-up commit.

Affected drivers can be determined with following pipeline, which should
return all driver_d structure instantiations that don't contain a name:

  ack --A 4 'struct driver_d.*' | perl -pe 's/^--$/\n/' | \
	perl -000 -ne 'print if /=.*\{.*\}/s && !/name/s'

With this change, these drivers should now give a more pleasant message:

  ERROR: initcall dw_wdt_driver_register+0x1/0xc failed: Invalid argument

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/base/driver.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index eec2a2d8a2a5..116ccb25864b 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -308,6 +308,9 @@ int register_driver(struct driver_d *drv)
 {
 	struct device_d *dev = NULL;
 
+	if (!drv->name)
+		return -EINVAL;
+
 	debug("register_driver: %s\n", drv->name);
 
 	BUG_ON(!drv->bus);
-- 
2.25.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox