From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] of: demote symbol copy error from warning to info
Date: Tue, 25 Feb 2020 08:51:11 +0100 [thread overview]
Message-ID: <20200225075111.GG3335@pengutronix.de> (raw)
In-Reply-To: <20200220065005.1387198-1-r.czerwinski@pengutronix.de>
On Thu, Feb 20, 2020 at 07:50:05AM +0100, Rouven Czerwinski wrote:
> An overlay might not contain a symbol node, in case it only adds new
> nodes to the device tree. Reword the error message and switch it from
> warning to info.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index de79e05cbc..9c1d5b5bcb 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -173,7 +173,7 @@ int of_overlay_apply_tree(struct device_node *root,
> /* Copy symbols from resolved overlay to base device tree */
> err = of_overlay_apply_symbols(root, resolved);
> if (err)
> - pr_warn("failed to copy symbols from overlay");
> + pr_info("could not copy symbols from overlay\n");
This message would still raise my eyebrows. Maybe move this message into
of_overlay_apply_symbols() and say something like "Overlay/root doesn't have
a __symbols__ node"?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2020-02-25 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:50 Rouven Czerwinski
2020-02-20 6:50 ` [PATCH 2/2] of: add missing newline to pr_warn Rouven Czerwinski
2020-02-25 7:52 ` Sascha Hauer
2020-02-25 7:51 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225075111.GG3335@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox