From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6Uzp-0006xD-8j for barebox@lists.infradead.org; Tue, 25 Feb 2020 07:51:14 +0000 Date: Tue, 25 Feb 2020 08:51:11 +0100 From: Sascha Hauer Message-ID: <20200225075111.GG3335@pengutronix.de> References: <20200220065005.1387198-1-r.czerwinski@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200220065005.1387198-1-r.czerwinski@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] of: demote symbol copy error from warning to info To: Rouven Czerwinski Cc: barebox@lists.infradead.org On Thu, Feb 20, 2020 at 07:50:05AM +0100, Rouven Czerwinski wrote: > An overlay might not contain a symbol node, in case it only adds new > nodes to the device tree. Reword the error message and switch it from > warning to info. > > Signed-off-by: Rouven Czerwinski > --- > drivers/of/overlay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c > index de79e05cbc..9c1d5b5bcb 100644 > --- a/drivers/of/overlay.c > +++ b/drivers/of/overlay.c > @@ -173,7 +173,7 @@ int of_overlay_apply_tree(struct device_node *root, > /* Copy symbols from resolved overlay to base device tree */ > err = of_overlay_apply_symbols(root, resolved); > if (err) > - pr_warn("failed to copy symbols from overlay"); > + pr_info("could not copy symbols from overlay\n"); This message would still raise my eyebrows. Maybe move this message into of_overlay_apply_symbols() and say something like "Overlay/root doesn't have a __symbols__ node"? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox