* [PATCH 1/2] of: demote symbol copy error from warning to info
@ 2020-02-20 6:50 Rouven Czerwinski
2020-02-20 6:50 ` [PATCH 2/2] of: add missing newline to pr_warn Rouven Czerwinski
2020-02-25 7:51 ` [PATCH 1/2] of: demote symbol copy error from warning to info Sascha Hauer
0 siblings, 2 replies; 4+ messages in thread
From: Rouven Czerwinski @ 2020-02-20 6:50 UTC (permalink / raw)
To: barebox; +Cc: Rouven Czerwinski
An overlay might not contain a symbol node, in case it only adds new
nodes to the device tree. Reword the error message and switch it from
warning to info.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/of/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index de79e05cbc..9c1d5b5bcb 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -173,7 +173,7 @@ int of_overlay_apply_tree(struct device_node *root,
/* Copy symbols from resolved overlay to base device tree */
err = of_overlay_apply_symbols(root, resolved);
if (err)
- pr_warn("failed to copy symbols from overlay");
+ pr_info("could not copy symbols from overlay\n");
/* Copy nodes and properties from resolved overlay to root */
for_each_child_of_node(resolved, fragment) {
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/2] of: add missing newline to pr_warn
2020-02-20 6:50 [PATCH 1/2] of: demote symbol copy error from warning to info Rouven Czerwinski
@ 2020-02-20 6:50 ` Rouven Czerwinski
2020-02-25 7:52 ` Sascha Hauer
2020-02-25 7:51 ` [PATCH 1/2] of: demote symbol copy error from warning to info Sascha Hauer
1 sibling, 1 reply; 4+ messages in thread
From: Rouven Czerwinski @ 2020-02-20 6:50 UTC (permalink / raw)
To: barebox; +Cc: Rouven Czerwinski
Add a missing newline to the pr_warn call while applying the overlays.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/of/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 9c1d5b5bcb..593be39428 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -179,7 +179,7 @@ int of_overlay_apply_tree(struct device_node *root,
for_each_child_of_node(resolved, fragment) {
err = of_overlay_apply_fragment(root, fragment);
if (err)
- pr_warn("failed to apply %s", fragment->name);
+ pr_warn("failed to apply %s\n", fragment->name);
}
of_delete_node(resolved);
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] of: demote symbol copy error from warning to info
2020-02-20 6:50 [PATCH 1/2] of: demote symbol copy error from warning to info Rouven Czerwinski
2020-02-20 6:50 ` [PATCH 2/2] of: add missing newline to pr_warn Rouven Czerwinski
@ 2020-02-25 7:51 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2020-02-25 7:51 UTC (permalink / raw)
To: Rouven Czerwinski; +Cc: barebox
On Thu, Feb 20, 2020 at 07:50:05AM +0100, Rouven Czerwinski wrote:
> An overlay might not contain a symbol node, in case it only adds new
> nodes to the device tree. Reword the error message and switch it from
> warning to info.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index de79e05cbc..9c1d5b5bcb 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -173,7 +173,7 @@ int of_overlay_apply_tree(struct device_node *root,
> /* Copy symbols from resolved overlay to base device tree */
> err = of_overlay_apply_symbols(root, resolved);
> if (err)
> - pr_warn("failed to copy symbols from overlay");
> + pr_info("could not copy symbols from overlay\n");
This message would still raise my eyebrows. Maybe move this message into
of_overlay_apply_symbols() and say something like "Overlay/root doesn't have
a __symbols__ node"?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-25 7:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 6:50 [PATCH 1/2] of: demote symbol copy error from warning to info Rouven Czerwinski
2020-02-20 6:50 ` [PATCH 2/2] of: add missing newline to pr_warn Rouven Czerwinski
2020-02-25 7:52 ` Sascha Hauer
2020-02-25 7:51 ` [PATCH 1/2] of: demote symbol copy error from warning to info Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox