* [PATCH] firmware: Fix dependencies for firmware in PBL
@ 2020-03-02 8:05 Sascha Hauer
2020-03-02 11:55 ` Rouven Czerwinski
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2020-03-02 8:05 UTC (permalink / raw)
To: Barebox List; +Cc: Ahmad Fatoum, Rouven Czerwinski
The object files for the PBL are not regenerated when the firmware files
are updated. The dependency from the pbl-*.gen.o to the firmware files
are missing, add them.
Reported-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
firmware/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/firmware/Makefile b/firmware/Makefile
index 9581ee6116..8e8ce83e06 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -50,6 +50,9 @@ $(patsubst %,$(obj)/%.gen.S, $(fw-external-y)): %: $(wordsize_deps) \
# The .o files depend on the binaries directly; the .S files don't.
$(patsubst %,$(obj)/%.gen.o, $(fw-external-y)): $(obj)/%.gen.o: $(fwdir)/%
+# The same for pbl:
+$(patsubst %,$(obj)/pbl-%.gen.o, $(fw-external-y)): $(obj)/pbl-%.gen.o: $(fwdir)/%
+
obj-pbl-y += $(patsubst %,%.gen.o, $(fw-external-y))
ifeq ($(KBUILD_SRC),)
--
2.25.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: Fix dependencies for firmware in PBL
2020-03-02 8:05 [PATCH] firmware: Fix dependencies for firmware in PBL Sascha Hauer
@ 2020-03-02 11:55 ` Rouven Czerwinski
0 siblings, 0 replies; 2+ messages in thread
From: Rouven Czerwinski @ 2020-03-02 11:55 UTC (permalink / raw)
To: Sascha Hauer, Barebox List; +Cc: Ahmad Fatoum
On Mon, 2020-03-02 at 09:05 +0100, Sascha Hauer wrote:
> The object files for the PBL are not regenerated when the firmware
> files
> are updated. The dependency from the pbl-*.gen.o to the firmware
> files
> are missing, add them.
>
> Reported-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Tested-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-02 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 8:05 [PATCH] firmware: Fix dependencies for firmware in PBL Sascha Hauer
2020-03-02 11:55 ` Rouven Czerwinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox